This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Hide autofill popup only when webcontent is focused #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There will be a follow-up cleanup in browser-laptop and I will mark issue fixed there. Address fcaecc2 Auditors: @bridiver, @bbondy, @bsclifton
darkdh
added a commit
to brave/browser-laptop
that referenced
this pull request
Mar 18, 2017
fix #7763 fix #7768 Auditors: @bridiver, @bbondy, @bsclifton Test Plan: Covered by automatic test
darkdh
added a commit
to brave/browser-laptop
that referenced
this pull request
Mar 18, 2017
requires brave/muon#170 fix #7763 fix #7768 Auditors: @bridiver, @bbondy, @bsclifton Test Plan: Covered by automatic test
4 tasks
This was referenced Mar 21, 2017
bsclifton
added a commit
to brave/browser-laptop
that referenced
this pull request
Mar 21, 2017
bridiver
reviewed
Mar 21, 2017
| @@ -196,7 +196,7 @@ void AtomAutofillClient::UpdateAutofillPopupDataListValues( | |||
| } | |||
|
|
|||
| void AtomAutofillClient::HideAutofillPopup() { | |||
| if (api_web_contents_) { | |||
| if (api_web_contents_ && api_web_contents_->IsFocused()) { | |||
There was a problem hiding this comment.
I'm not sure if this is the best way to handle this. I think the root of the problem is that we don't check the tabId before clearing the contextMenuDetail state in browser-laptop WINDOW_AUTOFILL_POPUP_HIDDEN, but if we are going to keep something like this I think it should track the current popup_visible state by setting it along with the calls to OnPopupShown and OnPopupHidden
There was a problem hiding this comment.
addressed in brave/browser-laptop@396cdbc
and we will keep api_web_contents_->IsFocused() for dismiss popup when scrolling page
darkdh
added a commit
to brave/browser-laptop
that referenced
this pull request
Mar 25, 2017
follow-up of brave/muon#170 (comment) Auditors: @bridiver, @bbondy Test Plan: Covered by automatic test
bsclifton
pushed a commit
to brave/browser-laptop
that referenced
this pull request
Mar 25, 2017
follow-up of brave/muon#170 (comment) Auditors: @bridiver, @bbondy Test Plan: Covered by automatic test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There will be a follow-up cleanup in browser-laptop and I will mark
issue fixed there.
Address fcaecc2
Auditors: @bridiver, @bbondy, @bsclifton