This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Make Linux sandbox error message more useful #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
reviewed
Mar 23, 2017
patches/v8/filter.patch
Outdated
| @@ -57,7 +57,7 @@ index 8587356ddcca34cdcad716ba7395666ec7ce4380..ad3e31e8ae859c0b02a57b6d2867ae4a | |||
| } | |||
| } | |||
| diff --git a/src/inspector/inspector.gyp b/src/inspector/inspector.gyp | |||
| index 6246f0ac0e7edfbe2272a577a648dcf08f868bb1..8dd41a110f63cb25f7bf3abfa9b42a3a910e78e0 100644 | |||
| index c70722f852b60831250b9c91bdf3abf71650425d..9a001e756ef61565cd144da12e63b49964693152 100644 | |||
There was a problem hiding this comment.
this doesn't look like it is supposed to be part of this change
There was a problem hiding this comment.
it was generated by npm run update_patches. running this command on muon/master with no chromium changes produces the following diff:
diff --git a/patches/v8/filter.patch b/patches/v8/filter.patch
index 066532349..aa5fb63fe 100644
--- a/patches/v8/filter.patch
+++ b/patches/v8/filter.patch
@@ -57,7 +57,7 @@ index 8587356ddcca34cdcad716ba7395666ec7ce4380..ad3e31e8ae859c0b02a57b6d2867ae4a
}
}
diff --git a/src/inspector/inspector.gyp b/src/inspector/inspector.gyp
-index 6246f0ac0e7edfbe2272a577a648dcf08f868bb1..8dd41a110f63cb25f7bf3abfa9b42a3a910e78e0 100644
+index c70722f852b60831250b9c91bdf3abf71650425d..9a001e756ef61565cd144da12e63b49964693152 100644
--- a/src/inspector/inspector.gyp
+++ b/src/inspector/inspector.gyp
@@ -4,7 +4,7 @@
There was a problem hiding this comment.
update_patches will pull in whatever you have locally, but this clearly isn't related to your changes so safer to just remove it I think
diracdeltas
force-pushed
the
fix/sandbox-error
branch
from
1b9f6e5 to
4953798
Compare
|
removed filter.patch diff |
|
++ |
18 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/browser-laptop#7210
Address brave/browser-laptop#6902 (comment)