This repository was archived by the owner on Jan 4, 2019. It is now read-only.
Implements chrome.windows.remove method #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
reviewed
Sep 5, 2017
lib/browser/api/extensions.js
Outdated
| if (win) { | ||
| win.close() | ||
| } else { | ||
| console.warn('chrome.windows.remove could not find windowId ' + windowId) |
There was a problem hiding this comment.
it isn't clear from the docs, but this method should set lastError if the window id doesn't exist. See tabs.remove in tabs_bindings.js for an example
jonathansampson
force-pushed
the
chrome.windows.remove
branch
from
0f63cd9 to
49e3069
Compare
|
@bridiver Now setting |
bridiver
approved these changes
Sep 20, 2017
|
please set branch labels/milestone |
bridiver
added a commit
that referenced
this pull request
Oct 12, 2017
Implements chrome.windows.remove method
bridiver
added a commit
that referenced
this pull request
Oct 21, 2017
Implements chrome.windows.remove method
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
chrome.windows.removemethod.Fixes brave/browser-laptop#8678