This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Implements chrome.windows.create #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinlawler
force-pushed
the
chrome.windows.create
branch
from
49afc2b
to
0b7e67c
Compare
bridiver
reviewed
Oct 14, 2017
| @@ -21,7 +21,16 @@ binding.registerCustomHook(function (bindingsAPI, extensionId) { | |||
| }) | |||
|
|
|||
| apiFunctions.setHandleRequest('create', function (createData, cb) { | |||
| console.warn('chrome.windows.create is not supported yet') | |||
| var responseId = ++id | |||
There was a problem hiding this comment.
we should be using ipc.guid() here. The integer ids can be duplicated across windows. Please update other uses in this file as well.
There was a problem hiding this comment.
if you have time please also update browser_action_bindings.js in a separate PR
There was a problem hiding this comment.
looks like also context_menu_bindings.js
13 tasks
bbondy
approved these changes
Oct 15, 2017
bbondy
added a commit
that referenced
this pull request
Oct 15, 2017
Implements chrome.windows.create
bbondy
added a commit
that referenced
this pull request
Oct 15, 2017
Implements chrome.windows.create
bridiver
pushed a commit
that referenced
this pull request
Oct 21, 2017
Implements chrome.windows.create
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work to add support for
chrome.windows.create.Resolves brave/browser-laptop#6789