This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Draft implementation of chrome.tabs.duplicate, #7458. #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
reviewed
Oct 25, 2017
| const duplicateTab = function (tabId, cb) { | ||
| try { | ||
| let tab = getWebContentsForTab(tabId) | ||
| // XXX What to do if not there? |
There was a problem hiding this comment.
set error to 'chrome.tabs.duplicate could not find tabId ' + tabId - I haven't actually verified that message against Chrome, but that would be consistent with the others
bridiver
reviewed
Oct 25, 2017
| evt.sender.send('chrome-tabs-duplicate-response-' + responseId, dtabValue, error) | ||
| } | ||
| } | ||
| try { |
There was a problem hiding this comment.
do we need both try/catch blocks (duplicateTab and this one)?
bridiver
reviewed
Oct 25, 2017
| try { | ||
| let tab = getWebContentsForTab(tabId) | ||
| // XXX What to do if not there? | ||
| tab._clone( |
There was a problem hiding this comment.
this should use clone instead of _clone. _clone is an internal method that is only meant to be used by web-contents.js
|
@riastradh @bridiver Anything (other than the requested changes) holding this PR back? |
|
Heh. Mostly that I don't check this github account! Paging my alter ego @riastradh-brave when it wakes up during work hours on Monday... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May not duplicate everything one might want duplicated -- it is a first-order approximation.
brave/browser-laptop#7458