Skip to content
This repository has been archived by the owner on Jan 4, 2019. It is now read-only.

Implement muon.crypto.encryptString/decryptString API #370

Merged
merged 2 commits into from
Dec 29, 2017

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Oct 31, 2017

master key is same as built-in password manager/cookies
Using base64 to encode non ASCII characters

fix brave/browser-laptop#10705

Auditors: @bridiver, @diracdeltas, @bbondy

master key is same as built-in password manager/cookies
Using base64 to encode non ASCII characters

fix brave/browser-laptop#10705

Auditors: @bridiver, @diracdeltas, @bbondy
@darkdh darkdh self-assigned this Oct 31, 2017
@darkdh
Copy link
Member Author

darkdh commented Oct 31, 2017

@bsclifton mentioned this might cause manually session backup failed because you can only encrypt/decrypt value on the same machine.
What do you think @diracdeltas ?

@darkdh
Copy link
Member Author

darkdh commented Nov 1, 2017

saved password and cookies applied to the same rules ^^^
so you can just copy those file to different machine

@diracdeltas
Copy link
Member

for safety, i think that muon.crypto.encryptString/decryptString should throw an error or return nothing if OSCrypt EncryptString/DecryptString are not available. In most cases, if a string cannot be encrypted, it is better to save nothing than to save it in plaintext.

@bridiver
Copy link
Collaborator

bridiver commented Nov 7, 2017

wouldn't it be better to just store them in the password manager? That has the added benefit of cross-device sync either through brave or through the OS encryption storage

@darkdh
Copy link
Member Author

darkdh commented Nov 9, 2017

we can do that on Mac and Window because password manager stores encrypted password in Login Data sql file but it stores the login entries in keyring

@diracdeltas
Copy link
Member

cc @riastradh for review of the underlying chromium crypto code

@bridiver bridiver added this to the 4.6.3 milestone Dec 29, 2017
@bridiver bridiver merged commit abc8b68 into master Dec 29, 2017
bridiver added a commit that referenced this pull request Dec 29, 2017
Implement muon.crypto.encryptString/decryptString API
@bsclifton bsclifton deleted the crypto_binding branch February 20, 2018 21:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

private wallet data in ledger state files should be encrypted using password manager
3 participants