This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Block filesystem access when cookies are blocked #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial fix for brave/browser-laptop#3214. Auditors: @bridiver
| content_settings_manager_->GetSetting( | ||
| GetOriginOrURL(frame), | ||
| secondary_url, | ||
| "cookies", |
There was a problem hiding this comment.
do we really want this to always be tied to cookies in electron or just tie the two settings together in browser-laptop? Seems like the latter would give us more flexibility
There was a problem hiding this comment.
i don't have a strong preference, but database and localstorage are tied to cookies, so this seems like it should be consistent with those
There was a problem hiding this comment.
ok, didn't think this was as closely related because Chrome handles it separately, but that's fine if it always makes sense together
|
++ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/browser-laptop#3214
auditors: @bridiver