set partition_domain for Tor browsing context #471
Conversation
| @@ -271,6 +271,10 @@ bool BraveBrowserContext::HasParentContext() { | |||
| return has_parent_; | |||
| } | |||
|
|
|||
| bool BraveBrowserContext::IsTorContext() { | |||
| return partition() == "tor"; | |||
There was a problem hiding this comment.
this is based on the fact that @riastradh-brave used tor as the partition name here: riastradh-brave/browser-laptop@0ec51b7#diff-2be38b3d97f35cd818780bac4be979c4R97
post-MVP, we will probably also have a persist:tor partition for adding Tor as a shields switch in regular tabs
There was a problem hiding this comment.
you can't have an in-memory partition that isn't associated with a persistent partition and we can't associate more than one incognito context with a Profile. The work @darkdh is doing should replace this anyway
There was a problem hiding this comment.
if i'm not mistaken this would also return true for persist:tor, so it would work if tor tabs were persistent session tabs (which i'll edit the browser-laptop branch to do)
|
i have updated the PR assuming that Tor tabs will be implemented as regular session tabs and an in_memory storage partition. let me know if this looks vaguely ok |
diracdeltas
force-pushed
the
tor/storage-partitions
branch
from
8e7aeeb to
fcfe5ce
Compare
|
closing since this will be covered by @darkdh's PR |
Fix #468
I haven't finished building this yet, just wanted to open a PR to get thoughts on whether this is the correct path