This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Prevent SuicideOnChannelErrorFilter to be added to tor_launcher utility process
#631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity process fix brave/browser-laptop#14636 SuicideOnChannelErrorFilter calls exit in OnChannelError() this will cause other endpoints listener can't finish their cleanup when pipe error happens(browser process crashed or be killed) and SuicideOnChannelErrorFilter::OnChannelError happens to be called before others. This should be fine for most of the cases but not tor_launcher service. `TorLauncher` requires StrongBinding::OnConnectionError to delete itself so that `~TorLauncher` will get called and terminate tor process. This should only happens on MacOS, SuicideOnChannelErrorFilter is guarded by OS_POSIX and Linux has `prctl(PR_SET_PDEATHSIG, SIGKILL)` so tor process will receive SIGKILL when tor_launcher utility process terminates prematurely Auditors: @riastradh-brave, @bridiver, @bbondy
|
@bridiver suggested using kqueue like I'm working on it |
|
just making a note that we should revisit this in brave-core and look at other options because this can still leave a zombie process in other cases |
bridiver
approved these changes
Jul 17, 2018
darkdh
added a commit
that referenced
this pull request
Jul 17, 2018
Prevent `SuicideOnChannelErrorFilter` to be added to tor_launcher utility process
darkdh
added a commit
that referenced
this pull request
Jul 18, 2018
Prevent `SuicideOnChannelErrorFilter` to be added to tor_launcher utility process
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/browser-laptop#14636
SuicideOnChannelErrorFilter calls exit in OnChannelError() this will
cause other endpoints listener can't finish their cleanup when pipe error
happens(browser process crashed or be killed) and
SuicideOnChannelErrorFilter::OnChannelError happens to be called before others.
This should be fine for most of the cases but not tor_launcher service.
TorLauncherrequires StrongBinding::OnConnectionError to delete itselfso that
~TorLauncherwill get called and terminate tor process.This should only happens on MacOS, SuicideOnChannelErrorFilter is
guarded by OS_POSIX and Linux has
prctl(PR_SET_PDEATHSIG, SIGKILL)so tor process will receive SIGKILL when tor_launcher utility process terminates
prematurely
Auditors: @riastradh-brave, @bridiver, @bbondy