This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
harden default web preferences #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
reviewed
Oct 25, 2016
| @@ -205,6 +205,8 @@ const attachGuest = function (embedder, elementInstanceId, guestInstanceId, para | |||
| zoomFactor: params.zoomFactor, | |||
| allowDisplayingInsecureContent: (ref1 = params.allowDisplayingInsecureContent) != null ? ref1 : false, | |||
| allowRunningInsecureContent: (ref1 = params.allowRunningInsecureContent) != null ? ref1 : false, | |||
| allowFileAccessFromFileUrls: (ref1 = params.allowFileAccessFromFileUrls) != null ? ref1 : false, | |||
There was a problem hiding this comment.
do we actually need these? We only ever set it to true for the main window
and prevent local files loaded in webviews from reading other files unless explicitly allowed by a webview attribute. fix brave/browser-laptop#4906 auditors: @bridiver
diracdeltas
force-pushed
the
fix/local-file-js
branch
from
a8ab45e to
997c364
Compare
diracdeltas
added a commit
to brave/browser-laptop
that referenced
this pull request
Oct 25, 2016
requires brave/muon#80 Auditors: @bridiver Test Plan: n/a
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and prevent local files loaded in webviews from reading other files unless
explicitly allowed by a webview attribute.
fix brave/browser-laptop#4906
auditors: @bridiver