Replace pdf source link #36
Conversation
|
Sounds good. Added pdf link for both http and https |
|
Added test links for mobile test runs as well |
|
Added the links for iOS too. Should be on all templates now |
wikitemplate-android.md
Outdated
| - [ ] Open a github issue and type some misspellings, make sure they are underlined. | ||
| - [ ] Make sure that right clicking on a word with suggestions gives a suggestion and that clicking on the suggestion replaces the text. | ||
| - [ ] Open an email on http://mail.google.com/ or inbox.google.com and click on a link. Make sure it works. | ||
| - [ ] Test that PDF is loaded over https at https://basicattentiontoken.org/BasicAttentionTokenWhitePaper--pdf |
There was a problem hiding this comment.
Should be https://basicattentiontoken.org/BasicAttentionTokenWhitePaper-4.pdf
wikitemplate-ios.md
Outdated
| - [ ] Load twitter and click on a tweet so the popup div shows. Click to dismiss and repeat with another div. Make sure it shows | ||
| - [ ] Go to https://trac.torproject.org/projects/tor/login and make sure that the password can be saved. Make sure the saved password is auto-populated when you visit the site again. | ||
| - [ ] Open an email on http://mail.google.com/ or inbox.google.com and click on a link. Make sure it works | ||
| - [ ] Test that PDF is loaded over https at https://basicattentiontoken.org/BasicAttentionTokenWhitePaper--pdf |
There was a problem hiding this comment.
Should be https://basicattentiontoken.org/BasicAttentionTokenWhitePaper-4.pdf
|
Fixed pdf links and updated fingerprint tests for browser-laptop based on brave/browser-laptop#12121 (comment) |
wikitemplate.md
Outdated
|
|
||
| **Fingerprinting Tests (Enable fingerprinting protection in `about:preferences#shields`)** | ||
| - [ ] Visit https://jsfiddle.net/bkf50r8v/13/, ensure 3 blocked items are listed in shields. Result window should show `got canvas fingerprint 0` and `got webgl fingerprint 00` | ||
| - [ ] Visit https://audiofingerprint.openwpm.com/, ensure 2 blocked items are listed in shields. Audio fingerprint graph is shown but doens't contain user fingerprint graph represented in blue line | ||
| - [ ] Test that browser is not detected on https://extensions.inrialpes.fr/brave/ |
There was a problem hiding this comment.
This should be moved above the Fingerprinting Tests as it's not related to FP... Test ensures that we're appearing as Chrome.
wikitemplate-ios.md
Outdated
| - [ ] Test that preferences default Bravery settings take effect on pages with no site settings. | ||
| - [ ] Test that turning on fingerprinting protection in preferences shows 1 fingerprints blocked at https://browserleaks.com/canvas . Test that turning it off in the Bravery menu shows 0 fingerprints blocked. | ||
| - [ ] Test that 3rd party storage results are blank at https://jsfiddle.net/7ke9r14a/7/ when 3rd party cookies are blocked. | ||
| - [ ] Test that audio fingerprint is blocked at https://audiofingerprint.openwpm.com/ when fingerprinting protection is on. | ||
|
|
There was a problem hiding this comment.
Should update the FP tests under iOS to match the formatting & structure of wikitemplate.md.
wikitemplate-android.md
Outdated
| - [ ] Test that about:preferences default Bravery settings take effect on pages with no site settings. | ||
| - [ ] Not Yet Implemented - Test that turning on fingerprinting protection in about:preferences shows 3 fingerprints blocked at https://jsfiddle.net/bkf50r8v/13/. Test that turning it off in the Bravery menu shows 0 fingerprints blocked. | ||
| - [ ] Test that 3rd party storage results are blank at https://jsfiddle.net/7ke9r14a/7/ when 3rd party cookies are blocked. | ||
| - [ ] Not Yet Implemented - Test that audio fingerprint is blocked at https://audiofingerprint.openwpm.com/ when fingerprinting protection is on. | ||
|
|
There was a problem hiding this comment.
Should update the FP tests under android to match the formatting & structure of wikitemplate.md.
|
Changed mobile template to match laptop template |
| - [ ] Visit https://jsfiddle.net/bkf50r8v/13/, ensure 3 blocked items are listed in shields. Result window should show `got canvas fingerprint 0` and `got webgl fingerprint 00` | ||
| - [ ] Visit https://audiofingerprint.openwpm.com/, ensure 2 blocked items are listed in shields. Audio fingerprint graph is shown but doens't contain user fingerprint graph represented in blue line | ||
|
|
||
|
|
| - [ ] Test that PDF is loaded over https at https://basicattentiontoken.org/BasicAttentionTokenWhitePaper-4.pdf | ||
| - [ ] Test that PDF is loaded over http at http://www.pdf995.com/samples/pdf.pdf | ||
| - [ ] Test that https://mixed-script.badssl.com/ shows up as grey not red (no mixed content scripts are run) | ||
| - [ ] Test that https://news.google.com/ sites open in a new tab (due to target being _blank) |
There was a problem hiding this comment.
mind wrapping _blank with backtick quotes as _ makes something wrapped italic?
| - [ ] Test that preferences default Bravery settings take effect on pages with no site settings. | ||
| - [ ] Test that 3rd party storage results are blank at https://jsfiddle.net/7ke9r14a/7/ when 3rd party cookies are blocked. | ||
|
|
||
| **Fingerprinting Tests (Enable fingerprinting protection in Settings)** |
There was a problem hiding this comment.
Should the iOS mobile templates use the same new FP cases as wikitemplate.md?
Example: got canvas fingerprint 0 and got webgl fingerprint 00
There was a problem hiding this comment.
For iOS there is only Canvas check done so the test url is also different compared to laptop. Can add it back later once security team says its the same result for mobile as well.
There was a problem hiding this comment.
the changes that @srirambv made to the wiki template recently should probably be reverted since the code change to fingerprinting protection in browser-laptop (brave/browser-laptop#11784) was reverted
| - [ ] Test that about:preferences default Bravery settings take effect on pages with no site settings. | ||
| - [ ] Test that 3rd party storage results are blank at https://jsfiddle.net/7ke9r14a/7/ when 3rd party cookies are blocked. | ||
|
|
||
| **Fingerprinting Tests (Enable fingerprinting protection in Settings)** |
There was a problem hiding this comment.
Should the android mobile templates use the same new FP cases as wikitemplate.md?
Example: got canvas fingerprint 0 and got webgl fingerprint 00
There was a problem hiding this comment.
@diracdeltas could confirm if the expected result is same for laptop and mobile
|
Closing in favour of #36 |
Closes #35