Skip to content
This repository has been archived by the owner on Oct 14, 2020. It is now read-only.

Add Android feedback collection endpoint #111

Merged
merged 3 commits into from
May 5, 2020
Merged

Conversation

aekeus
Copy link
Member

@aekeus aekeus commented Nov 22, 2019

  • Add an endpoint to collect feedback from a mobile device
  • Store feedback in Mongo
  • Add script to remove feedback entries by id or date
  • Add tests

Implements #110

@aekeus aekeus temporarily deployed to brave-laptop-updates-pre November 22, 2019 14:01 Inactive
@aekeus aekeus force-pushed the android-feedback branch from 2d52299 to 471dad2 Compare April 6, 2020 16:18
@aekeus aekeus requested a review from kkuehlz April 6, 2020 16:18
@kkuehlz
Copy link
Contributor

kkuehlz commented Apr 6, 2020

Let’s prioritize #117 and rebase this on top of that branch. I don’t want to introduce more code that needs security upgrade

@aekeus aekeus temporarily deployed to brave-laptop-updates-pre April 6, 2020 17:15 Inactive
aekeus and others added 3 commits May 4, 2020 16:34
  * Add an endpoint to collect feedback from a mobile device
  * Store feedback in Mongo
  * Add script to remove feedback entries by id or date
  * Add tests
  * assert we use non-deprecated moment.subtract(num, period)
  * close mongo client and not the connection
@kkuehlz kkuehlz force-pushed the android-feedback branch from 471dad2 to 4883e66 Compare May 4, 2020 23:41
Copy link
Member Author

@aekeus aekeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes looks good

@kkuehlz kkuehlz merged commit d86fd58 into master May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants