Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glossaries #10

Merged
merged 12 commits into from
Apr 3, 2019
Merged

Glossaries #10

merged 12 commits into from
Apr 3, 2019

Conversation

EmilyNecciai
Copy link
Contributor

Pull Request/Issue Resolution

Description of Change:
Adding Glossary Feature
Replacing Segmentation Filters tables with a searchable glossary
Adding Metrics Glossary
Reason for Change:
UX and adding more information.
Closes #9

PR Checklist

  • Ensure you have completed our CLA.
  • Tag @EmilyNecciai as a reviewer when the your work is done and ready to be reviewed for merge.
  • Consult the Docs Text Formatting Guide to be sure you're utilizing the proper markdown formatting.
  • Consult the Docs Writing Style Guide & Best Practices to be sure you're aligning with our voice and other style best practices.
  • Preview your deployed changes to confirm that none of your changes break production. Pay close attention to links and images.
  • Tag others as Reviewers as necessary.
  • If you have modified any links, be sure to add redirects to config/nginx.conf.erb.

@EmilyNecciai EmilyNecciai requested a review from a team as a code owner March 28, 2019 21:35
@cla-bot cla-bot bot added the cla-signed label Mar 28, 2019
@appboyci appboyci temporarily deployed to braze-docs-staging-pr-10 March 28, 2019 21:36 Inactive
@EmilyNecciai EmilyNecciai self-assigned this Mar 29, 2019
@appboyci appboyci temporarily deployed to braze-docs-staging-pr-10 March 29, 2019 12:56 Inactive
@appboyci appboyci temporarily deployed to braze-docs-staging-pr-10 March 29, 2019 18:38 Inactive
@appboyci appboyci temporarily deployed to braze-docs-staging-pr-10 March 29, 2019 18:49 Inactive
@appboyci appboyci temporarily deployed to braze-docs-staging-pr-10 March 29, 2019 18:56 Inactive
@appboyci appboyci temporarily deployed to braze-docs-staging-pr-10 April 3, 2019 12:17 Inactive
@appboyci appboyci temporarily deployed to braze-docs-staging-pr-10 April 3, 2019 12:27 Inactive
@appboyci appboyci temporarily deployed to braze-docs-staging-pr-10 April 3, 2019 13:00 Inactive
@EmilyNecciai EmilyNecciai requested a review from zzhaobraze April 3, 2019 13:15
@appboyci appboyci temporarily deployed to braze-docs-staging-pr-10 April 3, 2019 14:21 Inactive
zzhaobraze
zzhaobraze approved these changes Apr 3, 2019
View reviewed changes
Copy link
Collaborator

@zzhaobraze zzhaobraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@EmilyNecciai EmilyNecciai merged commit 590b371 into develop Apr 3, 2019
@EmilyNecciai EmilyNecciai deleted the en/glossary-page branch April 3, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzhaobraze zzhaobraze zzhaobraze approved these changes

Assignees

@EmilyNecciai EmilyNecciai

Labels
cla-signed status: in progress Work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Glossaries
3 participants
@EmilyNecciai @zzhaobraze @appboyci