Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cross-promotion cards from docs #17

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Remove cross-promotion cards from docs #17

merged 2 commits into from
Apr 3, 2019

Conversation

Bucimis
Copy link
Contributor

@Bucimis Bucimis commented Apr 1, 2019

No description provided.

@Bucimis Bucimis requested review from EmilyNecciai and dkim32 April 1, 2019 15:36
@Bucimis Bucimis requested a review from a team as a code owner April 1, 2019 15:36
@cla-bot cla-bot bot added the cla-signed label Apr 1, 2019
dkim32
dkim32 approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@dkim32 dkim32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Bucimis Bucimis requested a review from zzhaobraze April 1, 2019 19:46
@Bucimis
Copy link
Contributor Author

Bucimis commented Apr 2, 2019

@EmilyNecciai @zzhaobraze ping on this one

@EmilyNecciai
Copy link
Contributor

@Bucimis Is this something that is good to go live at any time?

@dkim32
Copy link
Contributor

dkim32 commented Apr 3, 2019

@Bucimis Is this something that is good to go live at any time?

@EmilyNecciai we're aiming for the may major release :)

@EmilyNecciai EmilyNecciai added the status: do not merge Could mean research before "in progress" status, or do not merge yet. label Apr 3, 2019
@EmilyNecciai
Copy link
Contributor

@dkim32 Great! Thank you!

@dkim32
Copy link
Contributor

dkim32 commented Apr 3, 2019

@Bucimis Is this something that is good to go live at any time?

@EmilyNecciai we're aiming for the may major release :)

i lied. i got this mixed up with the roku docs. this is good to go!

@EmilyNecciai EmilyNecciai added status: done Work is done and ready to be merged. and removed status: do not merge Could mean research before "in progress" status, or do not merge yet. labels Apr 3, 2019
EmilyNecciai
EmilyNecciai approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@EmilyNecciai EmilyNecciai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@EmilyNecciai EmilyNecciai merged commit b9b3348 into develop Apr 3, 2019
@EmilyNecciai EmilyNecciai deleted the xp-cards branch April 3, 2019 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkim32 dkim32 dkim32 approved these changes

@EmilyNecciai EmilyNecciai EmilyNecciai approved these changes

@zzhaobraze zzhaobraze Awaiting requested review from zzhaobraze

Assignees
No one assigned
Labels
cla-signed status: done Work is done and ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bucimis @EmilyNecciai @dkim32 @appboyci