Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContentCardsViewBindingHandler docs update #3743

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Conversation

chshapiro
Copy link
Contributor

Pull Request/Issue Resolution

Description of Change:

I'm changing..... (could be a link, a new image, a new section, etc.)... because...

Closes #ISSUE_NUMBER_HERE

Is this change associated with a Braze feature/product release?

  • Yes (Insert Feature Release Date Here)
  • No

✔️ Pull Request Checklist
  • Check that all links work.
  • Ensure you have completed our Contributors License Agreement.
  • Tag @timothy-kim and @KellieHawks as a reviewer when your work is done and ready to be reviewed for merge. Are you an internal product manager? Reference the interal reviewing chart to tag the appropriate reviewer.
  • Tag others as reviewers as necessary.
  • If you have modified any links, be sure to add redirects to assets > js > broken_redirect_list.js
⭐ Helpful Wiki Shortcuts
❗ ATTN: For PR Reviewers
  • Read our Reviewing a PR page for more on our reviewing suggestions.
  • Read our Previewing Documentation page to see how to check the deployment.
    • Preview all changes in the linked Vercel environment by clicking the preview link in the vercel-bot comment in your PR.
❗ ATTN: Internal Reviewing Chart
Work at Braze and not sure who to tag for review?
Before tagging @timothy-kim or @KellieHawks for a general review, reference the following chart to see if a specific product vertical/reviewer applies to your pull request.

Reviewer Product Vertical
@timothy-kim Data Infrastructure
Platform Infrastructure
Quality Infrastructure
@KellieHawks Internal Tools
Product Partnerships
SDKs
SMS
@bre-fitzgerald Channels
FIX
Intelligence
Reporting
SMB
@lydia-xie Email (Composition and Infrastructure)
Ingestion
Messaging

@vercel
Copy link

vercel bot commented Jul 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
braze-docs-en ✅ Ready (Inspect) Visit Preview Jul 5, 2022 at 6:46PM (UTC)

@cla-bot cla-bot bot added the cla-signed label Jul 5, 2022
@chshapiro chshapiro changed the title Update custom_styling.md ContentCardsViewBindingHandler docs update Jul 5, 2022
@chshapiro chshapiro requested review from radixdev and bryanlogan July 5, 2022 18:44
@chshapiro chshapiro added the status: do not merge Could mean research before "in progress" status, or do not merge yet. label Jul 6, 2022
@KellieHawks
Copy link
Contributor

@chshapiro Just checking in, do you have an anticipated date you'd like these changes pushed?

@Bucimis
Copy link
Contributor

Bucimis commented Oct 4, 2022

@KellieHawks please merge!

@KellieHawks KellieHawks removed the status: do not merge Could mean research before "in progress" status, or do not merge yet. label Oct 4, 2022
@KellieHawks KellieHawks merged commit 13c6728 into develop Oct 4, 2022
@KellieHawks KellieHawks deleted the SDK-2612-docsUpdate branch October 4, 2022 16:13
This was referenced Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants