Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-2800] - React Native + Expo updates #3815

Merged
merged 9 commits into from
Aug 12, 2022
Merged

[SDK-2800] - React Native + Expo updates #3815

merged 9 commits into from
Aug 12, 2022

Conversation

wesleyorbin
Copy link
Contributor

No description provided.

@wesleyorbin wesleyorbin requested a review from davidbielik July 23, 2022 03:35
@vercel
Copy link

vercel bot commented Jul 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
braze-docs-en ✅ Ready (Inspect) Visit Preview Aug 12, 2022 at 6:03PM (UTC)
braze-docs-fr ✅ Ready (Inspect) Visit Preview Aug 12, 2022 at 6:03PM (UTC)

@wesleyorbin wesleyorbin marked this pull request as ready for review July 26, 2022 17:55
@wesleyorbin wesleyorbin requested a review from davidbielik July 26, 2022 17:55
davidbielik
davidbielik previously approved these changes Aug 10, 2022
| ------------------------------------| ---------| -------------------------------------------------------------------------------------------------------------------------------------------------------|
| `androidApiKey` | string | Required. The API key for your Android application. |
| `iosApiKey` | string | Required. The API key for your iOS application. |
| `customEndpoint` | string | Required. The [SDK endpoint]({{site.baseurl}}/api/basics/#endpoints) for your application. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be baseUrl to match web?

davidbielik
davidbielik previously approved these changes Aug 10, 2022
@davidbielik
Copy link
Contributor

@wesleyorbin all looks good, i made a few edits. only open question is the customEndpoint naming vs. baseUrl but i wasn't sure if that's by choice or not.

@wesleyorbin
Copy link
Contributor Author

wesleyorbin commented Aug 10, 2022

@wesleyorbin all looks good, i made a few edits. only open question is the customEndpoint naming vs. baseUrl but i wasn't sure if that's by choice or not.

It is called customEndpoint in the plugin, but you're probably right that we should rename it. We can make a story to add that along with the next breaking change. Though I guess there's a question of whether we should try to match web or mobile for these config options.

@KellieHawks KellieHawks merged commit d4e8809 into develop Aug 12, 2022
@KellieHawks KellieHawks deleted the SDK-2800 branch August 12, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants