[SDK-2825] InAppMessages using Flutter Streams #3829

vanessaland · 2022-07-27T17:05:33Z

https://jira.braze.com/browse/SDK-2825

(This change is for both iOS and Android)

Pull Request/Issue Resolution

Description of Change:

I'm changing the Platform Integration Guides/Flutter/InAppMessages page because I am adding our new support for Dart Streams in iOS. (Note: This pull request cannot be merged until support for Android is completed.)

Added a section Receiving in-app message data to include information supported by both methods
Added an additional section for Flutter Streams Method 1: In-app message data streams (Recommended)
Renamed original section to Method 2: In-app message data callback (Legacy)

Closes #SDK-2825

Is this change associated with a Braze feature/product release?

Yes - Flutter version 2.6.0
No

✔️ Pull Request Checklist

Check that all links work.
Ensure you have completed our Contributors License Agreement.
Tag @timothy-kim and @KellieHawks as a reviewer when your work is done and ready to be reviewed for merge. Are you an internal product manager? Reference the interal reviewing chart to tag the appropriate reviewer.
Tag others as reviewers as necessary.
If you have modified any links, be sure to add redirects to assets > js > broken_redirect_list.js

⭐ Helpful Wiki Shortcuts

❗ ATTN: For PR Reviewers

Read our Reviewing a PR page for more on our reviewing suggestions.
Read our Previewing Documentation page to see how to check the deployment.
- Preview all changes in the linked Vercel environment by clicking the preview link in the vercel-bot comment in your PR.

❗ ATTN: Internal Reviewing Chart

Work at Braze and not sure who to tag for review?
Before tagging @timothy-kim or @KellieHawks for a general review, reference the following chart to see if a specific product vertical/reviewer applies to your pull request.

Reviewer	Product Vertical
@timothy-kim	Data Infrastructure Platform Infrastructure Quality Infrastructure
@KellieHawks	Internal Tools Product Partnerships SDKs SMS
@bre-fitzgerald	Channels FIX Intelligence Reporting SMB
@lydia-xie	Email (Composition and Infrastructure) Ingestion Messaging

vercel · 2022-07-27T17:05:36Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
braze-docs-en	✅ Ready (Inspect)	Visit Preview	Sep 28, 2022 at 3:22PM (UTC)

1 Ignored Deployment

Name	Status	Preview	Updated
braze-docs-fr	⬜️ Ignored (Inspect)		Sep 28, 2022 at 3:22PM (UTC)

cla-bot · 2022-07-27T17:05:37Z

We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please fill out the information here. To re-call the cla-bot, comment @cla-bot check.

_docs/_developer_guide/platform_integration_guides/flutter/inapp_messages.md

Bucimis

Looks good once the ordering is addressed.

Note, we can't merge this PR until Android is complete

_docs/_developer_guide/platform_integration_guides/flutter/inapp_messages.md

…pp_messages.md Co-authored-by: Daniel Hok <4797040+hokstuff@users.noreply.github.com>

hokstuff

Small nits, LGTM after

_docs/_developer_guide/platform_integration_guides/flutter/inapp_messages.md

…pp_messages.md Co-authored-by: Daniel Hok <4797040+hokstuff@users.noreply.github.com>

_docs/_developer_guide/platform_integration_guides/flutter/inapp_messages.md

Co-authored-by: Jared Poelman <jared@braze.com>

…25-flutter-streams-ios

bre-fitzgerald

lgtm! This one is also marked as do not merge, ready to go? 👀

hokstuff · 2022-10-05T22:54:14Z

@bre-fitzgerald You can merge this PR as well!

vanessaland added 2 commits July 27, 2022 12:48

added the new flutter streams method for iOS

c5e1e02

factored out similar content between 2 methods

7f0ba33

vanessaland added the status: do not merge Could mean research before "in progress" status, or do not merge yet. label Jul 27, 2022

vanessaland requested review from hokstuff, Bucimis and chshapiro August 1, 2022 15:17

This comment was marked as resolved.

Sign in to view

cla-bot bot added the cla-signed label Aug 1, 2022

This comment was marked as resolved.

Sign in to view

hokstuff reviewed Aug 1, 2022

View reviewed changes

_docs/_developer_guide/platform_integration_guides/flutter/inapp_messages.md Outdated Show resolved Hide resolved

_docs/_developer_guide/platform_integration_guides/flutter/inapp_messages.md Outdated Show resolved Hide resolved

Bucimis reviewed Aug 1, 2022

View reviewed changes

_docs/_developer_guide/platform_integration_guides/flutter/inapp_messages.md Outdated Show resolved Hide resolved

Update _docs/_developer_guide/platform_integration_guides/flutter/ina…

254480c

…pp_messages.md Co-authored-by: Daniel Hok <4797040+hokstuff@users.noreply.github.com>

vercel bot deployed to Preview August 2, 2022 18:13 View deployment

updated spelling of "two" instead of 2

4cb4cd0

vercel bot deployed to Preview August 2, 2022 18:29 View deployment

updated order of 2 methods + added "legacy" and "recommended"

c0dc9ea

vercel bot deployed to Preview August 2, 2022 19:15 View deployment

added a note for legacy and recommended

a3774b7

vercel bot had a problem deploying to Preview August 2, 2022 19:36 Failure

updated wording

fb2f22e

vercel bot deployed to Preview August 2, 2022 19:39 View deployment

vanessaland requested review from Bucimis and hokstuff August 2, 2022 19:52

hokstuff previously approved these changes Aug 2, 2022

View reviewed changes

_docs/_developer_guide/platform_integration_guides/flutter/inapp_messages.md Outdated Show resolved Hide resolved

_docs/_developer_guide/platform_integration_guides/flutter/inapp_messages.md Outdated Show resolved Hide resolved

vanessaland dismissed hokstuff’s stale review via 322e2fb August 3, 2022 21:12

vanessaland and others added 2 commits August 3, 2022 17:12

Update _docs/_developer_guide/platform_integration_guides/flutter/ina…

322e2fb

…pp_messages.md Co-authored-by: Daniel Hok <4797040+hokstuff@users.noreply.github.com>

Update _docs/_developer_guide/platform_integration_guides/flutter/ina…

4ec903d

…pp_messages.md Co-authored-by: Daniel Hok <4797040+hokstuff@users.noreply.github.com>

vercel bot deployed to Preview August 3, 2022 21:15 View deployment

vercel bot deployed to Preview August 5, 2022 19:41 View deployment

hokstuff changed the title ~~[SDK-2825] InAppMessages using Flutter Streams for iOS~~ [SDK-2825] InAppMessages using Flutter Streams Sep 27, 2022

hokstuff self-assigned this Sep 27, 2022

hokstuff marked this pull request as ready for review September 27, 2022 18:42

Add type to IAM closure in sample code

4cff644

vercel bot had a problem deploying to Preview – braze-docs-fr September 27, 2022 18:52 Failure

vercel bot had a problem deploying to Preview – braze-docs-en September 27, 2022 18:54 Failure

Bucimis previously approved these changes Sep 27, 2022

View reviewed changes

hokstuff dismissed Bucimis’s stale review via b437294 September 27, 2022 22:27

Apply suggestions from code review

b437294

Co-authored-by: Jared Poelman <jared@braze.com>

vercel bot had a problem deploying to Preview – braze-docs-fr September 27, 2022 22:28 Failure

Update inapp_messages.md

ca4bc72

vercel bot had a problem deploying to Preview – braze-docs-fr September 27, 2022 22:29 Failure

vercel bot had a problem deploying to Preview – braze-docs-en September 27, 2022 22:29 Failure

Update inapp_messages.md

31935a4

vercel bot had a problem deploying to Preview – braze-docs-en September 27, 2022 22:33 Failure

hokstuff requested a review from bre-fitzgerald September 27, 2022 22:33

vercel bot had a problem deploying to Preview – braze-docs-fr September 27, 2022 22:33 Failure

Merge branch 'develop' of github.com:braze-inc/braze-docs into SDK-28…

4f75a55

…25-flutter-streams-ios

vercel bot deployed to Preview – braze-docs-en September 28, 2022 15:11 View deployment

Minor style edits

fa6d71e

vercel bot deployed to Preview – braze-docs-en September 28, 2022 15:22 View deployment

bre-fitzgerald approved these changes Sep 28, 2022

View reviewed changes

hokstuff mentioned this pull request Sep 28, 2022

[SDK-2854] ContentCards using Flutter Streams #3879

Merged

10 tasks

KellieHawks approved these changes Oct 6, 2022

View reviewed changes

KellieHawks merged commit 39b9009 into develop Oct 6, 2022

KellieHawks deleted the SDK-2825-flutter-streams-ios branch October 6, 2022 14:07

KellieHawks removed the status: do not merge Could mean research before "in progress" status, or do not merge yet. label Oct 6, 2022

KellieHawks mentioned this pull request Oct 6, 2022

Leftover Deploy - October 6, 2022 #4187

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SDK-2825] InAppMessages using Flutter Streams #3829

[SDK-2825] InAppMessages using Flutter Streams #3829

vanessaland commented Jul 27, 2022 •

edited by hokstuff

Loading

vercel bot commented Jul 27, 2022 •

edited

Loading

cla-bot bot commented Jul 27, 2022

This comment was marked as resolved.

This comment was marked as resolved.

Bucimis left a comment

hokstuff left a comment

bre-fitzgerald left a comment

hokstuff commented Oct 5, 2022

[SDK-2825] InAppMessages using Flutter Streams #3829

[SDK-2825] InAppMessages using Flutter Streams #3829

Conversation

vanessaland commented Jul 27, 2022 • edited by hokstuff Loading

Pull Request/Issue Resolution

Description of Change:

Is this change associated with a Braze feature/product release?

vercel bot commented Jul 27, 2022 • edited Loading

cla-bot bot commented Jul 27, 2022

This comment was marked as resolved.

This comment was marked as resolved.

Bucimis left a comment

Choose a reason for hiding this comment

hokstuff left a comment

Choose a reason for hiding this comment

bre-fitzgerald left a comment

Choose a reason for hiding this comment

hokstuff commented Oct 5, 2022

vanessaland commented Jul 27, 2022 •

edited by hokstuff

Loading

vercel bot commented Jul 27, 2022 •

edited

Loading