Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web SDK note to OTT documentation #3918

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Add web SDK note to OTT documentation #3918

merged 1 commit into from
Aug 12, 2022

Conversation

spvismaya
Copy link
Contributor

Pull Request/Issue Resolution

Description of Change:

Adding a note to OTT documentation that using CDN version of web sdk is preferred (and reason why)

Closes #ISSUE_NUMBER_HERE

Is this change associated with a Braze feature/product release?

  • Yes (Insert Feature Release Date Here)
  • No

✔️ Pull Request Checklist
  • Check that all links work.
  • Ensure you have completed our Contributors License Agreement.
  • Tag @timothy-kim and @KellieHawks as a reviewer when your work is done and ready to be reviewed for merge. Are you an internal product manager? Reference the interal reviewing chart to tag the appropriate reviewer.
  • Tag others as reviewers as necessary.
  • If you have modified any links, be sure to add redirects to assets > js > broken_redirect_list.js
⭐ Helpful Wiki Shortcuts
❗ ATTN: For PR Reviewers
  • Read our Reviewing a PR page for more on our reviewing suggestions.
  • Read our Previewing Documentation page to see how to check the deployment.
    • Preview all changes in the linked Vercel environment by clicking the preview link in the vercel-bot comment in your PR.
❗ ATTN: Internal Reviewing Chart
Work at Braze and not sure who to tag for review?
Before tagging @timothy-kim or @KellieHawks for a general review, reference the following chart to see if a specific product vertical/reviewer applies to your pull request.

Reviewer Product Vertical
@timothy-kim Data Infrastructure
Platform Infrastructure
Quality Infrastructure
@KellieHawks Internal Tools
Product Partnerships
SDKs
SMS
@bre-fitzgerald Channels
FIX
Intelligence
Reporting
SMB
@lydia-xie Email (Composition and Infrastructure)
Ingestion
Messaging

@vercel
Copy link

vercel bot commented Aug 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
braze-docs-en ✅ Ready (Inspect) Visit Preview Aug 11, 2022 at 8:31PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
braze-docs-fr ⬜️ Ignored (Inspect) Aug 11, 2022 at 8:31PM (UTC)

@cla-bot
Copy link

cla-bot bot commented Aug 11, 2022

We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please fill out the information here. To re-call the cla-bot, comment @cla-bot check.

@spvismaya
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Aug 11, 2022
@cla-bot
Copy link

cla-bot bot commented Aug 11, 2022

The cla-bot has been summoned, and re-checked this pull request!

@spvismaya spvismaya marked this pull request as ready for review August 11, 2022 20:37
Copy link
Contributor

@davidbielik davidbielik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@KellieHawks KellieHawks merged commit 5b68cc1 into develop Aug 12, 2022
@KellieHawks KellieHawks deleted the SDK-2838 branch August 12, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants