Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification for Devs Inexperienced with Push #3937

Merged
merged 7 commits into from
Aug 24, 2022

Conversation

SimeonBraze
Copy link
Contributor

Pull Request/Issue Resolution

Description of Change:

Often when dealing with devs that are inexperienced with push notifications I find that they follow some guide they find online and request push permissions in the startup code. We often need to tell them not to do this. This is more of a problem when the Braze SDK will be handling this for them now.

Closes #ISSUE_NUMBER_HERE

Is this change associated with a Braze feature/product release?

  • Yes (Insert Feature Release Date Here)
  • [ X] No

✔️ Pull Request Checklist
  • [X ] Check that all links work.
  • [ X] Ensure you have completed our Contributors License Agreement.
  • Tag @timothy-kim and @KellieHawks as a reviewer when your work is done and ready to be reviewed for merge. Are you an internal product manager? Reference the interal reviewing chart to tag the appropriate reviewer.
  • Tag others as reviewers as necessary.
  • [X ] If you have modified any links, be sure to add redirects to assets > js > broken_redirect_list.js
⭐ Helpful Wiki Shortcuts
❗ ATTN: For PR Reviewers
  • Read our Reviewing a PR page for more on our reviewing suggestions.
  • Read our Previewing Documentation page to see how to check the deployment.
    • Preview all changes in the linked Vercel environment by clicking the preview link in the vercel-bot comment in your PR.
❗ ATTN: Internal Reviewing Chart
Work at Braze and not sure who to tag for review?
Before tagging @timothy-kim or @KellieHawks for a general review, reference the following chart to see if a specific product vertical/reviewer applies to your pull request.

Reviewer Product Vertical
@timothy-kim Data Infrastructure
Platform Infrastructure
Quality Infrastructure
@KellieHawks Internal Tools
Product Partnerships
SDKs
SMS
@bre-fitzgerald Channels
FIX
Intelligence
Reporting
SMB
@lydia-xie Email (Composition and Infrastructure)
Ingestion
Messaging

Often when dealing with devs that are inexperienced with push notifications I find that they follow some guide they find online and request push permissions in the startup code. We often need to tell them not to do this. This is more of a problem when the Braze SDK will be handling this for them now.
@vercel
Copy link

vercel bot commented Aug 16, 2022

@SimeonBraze is attempting to deploy a commit to the Braze Team on Vercel.

A member of the Team first needs to authorize it.

@cla-bot cla-bot bot added the cla-signed label Aug 16, 2022
@bre-fitzgerald
Copy link
Collaborator

Hey @SimeonBraze, thanks for contributing to our docs! I'm unsure if putting this information in the push primer documentation makes sense. This seems like it might be better suited to push integration docs. @davidbielik can you take a look at this?

cc: @KellieHawks

@SimeonBraze
Copy link
Contributor Author

Hey @bre-fitzgerald, I am not sure it works there either as those docs make reference to the old way of push priming without the the built in IAM functionality. It might be push priming in the development sections also needs rework/removal once the iOS 5.1.0 SDK is live.

I actually forgot to include it in this pull request but a couple extra things I think we need to include in this page. I can park these for another pull request if you want.

  • The recommended filter is “Push Subscription Status is not Opted In”, however as we may know, push enabled status is at a device level, not user level. This solution doesn’t cater for the scenario where 1 user might have multiple iOS devices and multiple Android devices.
  • It mentioned tracking conversions, but Braze doesn’t provide an out-of-the-box drop-down to track push-enabled events.

@SimeonBraze
Copy link
Contributor Author

One more thing sorry. We have found that markers attempt to use this functionality and wonder why it isn't working when either the SDK isn't supported or the development team haven't properly implemented it. I think we should do more to tell potential users they may need to do more validation before attempting to use this feature.

@@ -24,6 +24,28 @@ This guide uses a button [on-click behavior](#button-actions) that is only suppo

{% sdk_min_versions ios:5.1.0 android:21.0.0 web:4.0.3 %}

### Note for Development Teams

When implementing push notifications for the first time it is common to include the below, or simillar, in app startup code. For this push priming process to work as expected, it is important you do not implement any push registration code. The implementation is handled by the Braze SDK.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or

Suggested change
When implementing push notifications for the first time it is common to include the below, or simillar, in app startup code. For this push priming process to work as expected, it is important you do not implement any push registration code. The implementation is handled by the Braze SDK.
You should remove any code that manually requests the push permission prompt to be shown to avoid showing the native prompt too early. This new Braze in-app message feature will automatically handle push permission prompts when the user clicks the button.

@davidbielik
Copy link
Contributor

  • The recommended filter is “Push Subscription Status is not Opted In”, however as we may know, push enabled status is at a device level, not user level. This solution doesn’t cater for the scenario where 1 user might have multiple iOS devices and multiple Android devices.

We have a "Push Enabled for App" filter. isn't that a better one to use?

  • It mentioned tracking conversions, but Braze doesn’t provide an out-of-the-box drop-down to track push-enabled events.

The IAM can still track button1/button2 clicks, though not the same as tracking opt-in rates.

@vercel
Copy link

vercel bot commented Aug 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
braze-docs-en ✅ Ready (Inspect) Visit Preview Aug 24, 2022 at 5:28PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
braze-docs-fr ⬜️ Ignored (Inspect) Aug 24, 2022 at 5:28PM (UTC)

@SimeonBraze
Copy link
Contributor Author

Thanks for the changes, yours is much better.

We have a "Push Enabled for App" filter. isn't that a better one to use?
This is still at a user level not a device level. For example, a user has iPhone 12 and is push subscribed on that phone. They then buy an iPhone 13 and install the app. Because the iPhone 12 is still push subscribed in Braze they won't receive an IAM prompt because those filters are at a user level not a device level.

The IAM can still track button1/button2 clicks, though not the same as tracking opt-in rates.
Yes i think the idea is we have no idea whether the user actually opted into push on that device after pushing button 1.

KellieHawks and others added 6 commits August 24, 2022 12:55
…_messages.md

Co-authored-by: davidbielik <davidbielik@users.noreply.github.com>
…_messages.md

Co-authored-by: davidbielik <davidbielik@users.noreply.github.com>
…_messages.md

Co-authored-by: davidbielik <davidbielik@users.noreply.github.com>
…_messages.md

Co-authored-by: davidbielik <davidbielik@users.noreply.github.com>
…_messages.md

Co-authored-by: davidbielik <davidbielik@users.noreply.github.com>
@KellieHawks KellieHawks self-requested a review August 24, 2022 17:42
@KellieHawks KellieHawks merged commit 248f5a2 into braze-inc:develop Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants