-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarification for Devs Inexperienced with Push #3937
Conversation
Often when dealing with devs that are inexperienced with push notifications I find that they follow some guide they find online and request push permissions in the startup code. We often need to tell them not to do this. This is more of a problem when the Braze SDK will be handling this for them now.
@SimeonBraze is attempting to deploy a commit to the Braze Team on Vercel. A member of the Team first needs to authorize it. |
Hey @SimeonBraze, thanks for contributing to our docs! I'm unsure if putting this information in the push primer documentation makes sense. This seems like it might be better suited to push integration docs. @davidbielik can you take a look at this? cc: @KellieHawks |
Hey @bre-fitzgerald, I am not sure it works there either as those docs make reference to the old way of push priming without the the built in IAM functionality. It might be push priming in the development sections also needs rework/removal once the iOS 5.1.0 SDK is live. I actually forgot to include it in this pull request but a couple extra things I think we need to include in this page. I can park these for another pull request if you want.
|
One more thing sorry. We have found that markers attempt to use this functionality and wonder why it isn't working when either the SDK isn't supported or the development team haven't properly implemented it. I think we should do more to tell potential users they may need to do more validation before attempting to use this feature. |
_docs/_user_guide/message_building_by_channel/push/push_primer_messages.md
Outdated
Show resolved
Hide resolved
_docs/_user_guide/message_building_by_channel/push/push_primer_messages.md
Show resolved
Hide resolved
_docs/_user_guide/message_building_by_channel/push/push_primer_messages.md
Outdated
Show resolved
Hide resolved
_docs/_user_guide/message_building_by_channel/push/push_primer_messages.md
Outdated
Show resolved
Hide resolved
_docs/_user_guide/message_building_by_channel/push/push_primer_messages.md
Outdated
Show resolved
Hide resolved
@@ -24,6 +24,28 @@ This guide uses a button [on-click behavior](#button-actions) that is only suppo | |||
|
|||
{% sdk_min_versions ios:5.1.0 android:21.0.0 web:4.0.3 %} | |||
|
|||
### Note for Development Teams | |||
|
|||
When implementing push notifications for the first time it is common to include the below, or simillar, in app startup code. For this push priming process to work as expected, it is important you do not implement any push registration code. The implementation is handled by the Braze SDK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or
When implementing push notifications for the first time it is common to include the below, or simillar, in app startup code. For this push priming process to work as expected, it is important you do not implement any push registration code. The implementation is handled by the Braze SDK. | |
You should remove any code that manually requests the push permission prompt to be shown to avoid showing the native prompt too early. This new Braze in-app message feature will automatically handle push permission prompts when the user clicks the button. |
We have a "Push Enabled for App" filter. isn't that a better one to use?
The IAM can still track button1/button2 clicks, though not the same as tracking opt-in rates. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Thanks for the changes, yours is much better.
|
…_messages.md Co-authored-by: davidbielik <davidbielik@users.noreply.github.com>
…_messages.md Co-authored-by: davidbielik <davidbielik@users.noreply.github.com>
…_messages.md Co-authored-by: davidbielik <davidbielik@users.noreply.github.com>
…_messages.md Co-authored-by: davidbielik <davidbielik@users.noreply.github.com>
…_messages.md Co-authored-by: davidbielik <davidbielik@users.noreply.github.com>
Pull Request/Issue Resolution
Description of Change:
Often when dealing with devs that are inexperienced with push notifications I find that they follow some guide they find online and request push permissions in the startup code. We often need to tell them not to do this. This is more of a problem when the Braze SDK will be handling this for them now.
Closes #ISSUE_NUMBER_HERE
Is this change associated with a Braze feature/product release?
✔️ Pull Request Checklist
assets
>js
>broken_redirect_list.js
⭐ Helpful Wiki Shortcuts
❗ ATTN: For PR Reviewers
❗ ATTN: Internal Reviewing Chart
Work at Braze and not sure who to tag for review?
Before tagging @timothy-kim or @KellieHawks for a general review, reference the following chart to see if a specific product vertical/reviewer applies to your pull request.
Platform Infrastructure
Quality Infrastructure
Product Partnerships
SDKs
SMS
FIX
Intelligence
Reporting
SMB
Ingestion
Messaging