Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to docs from CSM solutions repository #4201

Merged
merged 26 commits into from
Oct 21, 2022
Merged

Updates to docs from CSM solutions repository #4201

merged 26 commits into from
Oct 21, 2022

Conversation

KellieHawks
Copy link
Contributor

Pull Request/Issue Resolution

Description of Change:

I'm changing..... (could be a link, a new image, a new section, etc.)... because...

Closes #ISSUE_NUMBER_HERE

Is this change associated with a Braze feature/product release?

  • Yes (Insert Feature Release Date Here)
  • No
✔️ Pull Request Checklist
  • Check that all links work.
  • Ensure you have completed our Contributors License Agreement.
  • Tag @timothy-kim and @KellieHawks as a reviewer when your work is done and ready to be reviewed for merge. Are you an internal product manager? Reference the internal reviewing chart to tag the appropriate reviewer.
  • Tag others as reviewers as necessary.
  • If you have modified any links, be sure to add redirects to assets > js > broken_redirect_list.js
⭐ Helpful Wiki Shortcuts
❗ ATTN: For PR Reviewers
  • Read our Reviewing a PR page for more on our reviewing suggestions.
  • Read our Previewing Documentation page to see how to check the deployment.
    • Preview all changes in the linked Vercel environment by clicking the preview link in the vercel-bot comment in your PR.
❗ ATTN: Internal Reviewing Chart
Work at Braze and not sure who to tag for review?
Before tagging @timothy-kim or @KellieHawks for a general review, reference the following chart to see if a specific product vertical/reviewer applies to your pull request.

Reviewer Product Vertical
@timothy-kim Data Infrastructure
Platform Infrastructure
Quality Infrastructure
@KellieHawks Internal Tools
Product Partnerships
SDKs
SMS
@bre-fitzgerald Channels
FIX
Intelligence
Reporting
SMB
@lydia-xie Email (Composition and Infrastructure)
Ingestion
Messaging

@vercel
Copy link

vercel bot commented Oct 7, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
braze-docs-en ✅ Ready (Inspect) Visit Preview Oct 21, 2022 at 2:46PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
braze-docs-fr ⬜️ Ignored (Inspect) Oct 21, 2022 at 2:46PM (UTC)

@cla-bot cla-bot bot added the cla-signed label Oct 7, 2022
bre-fitzgerald
bre-fitzgerald requested changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@bre-fitzgerald bre-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Left a few minor comments for some grammar fixes and clarifications.

_docs/_api/api_campaigns.md Outdated Show resolved Hide resolved
_docs/_user_guide/data_and_analytics/braze_currents.md Outdated Show resolved Hide resolved
_docs/_user_guide/data_and_analytics/custom_data/custom_events.md Outdated Show resolved Hide resolved
_docs/_user_guide/data_and_analytics/custom_data/custom_events.md Outdated Show resolved Hide resolved
_docs/_user_guide/data_and_analytics/custom_data/custom_events.md Outdated Show resolved Hide resolved
_docs/_user_guide/data_and_analytics/custom_data/custom_events.md Outdated Show resolved Hide resolved
_docs/_user_guide/data_and_analytics/user_data_collection/best_practices.md Outdated Show resolved Hide resolved
_docs/_user_guide/personalization_and_dynamic_content/liquid/liquid_use_cases.md Outdated Show resolved Hide resolved
_docs/_user_guide/personalization_and_dynamic_content/liquid/liquid_use_cases.md Outdated Show resolved Hide resolved
_docs/_user_guide/personalization_and_dynamic_content/liquid/liquid_use_cases.md Outdated Show resolved Hide resolved
lydia-xie
lydia-xie requested changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@lydia-xie lydia-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! left two small suggestions

_docs/_user_guide/data_and_analytics/braze_currents.md Outdated Show resolved Hide resolved
_docs/_user_guide/data_and_analytics/custom_data/custom_attributes.md Outdated Show resolved Hide resolved
KellieHawks and others added 12 commits October 21, 2022 10:33
@KellieHawks @lydia-xie
Update _docs/_user_guide/data_and_analytics/braze_currents.md
132574c 
Co-authored-by: Lydia Xie <87040416+lydia-xie@users.noreply.github.com>
@KellieHawks @lydia-xie
Update _docs/_user_guide/data_and_analytics/custom_data/custom_attrib…
0c43503 
…utes.md

Co-authored-by: Lydia Xie <87040416+lydia-xie@users.noreply.github.com>
@KellieHawks @bre-fitzgerald
Update _docs/_user_guide/personalization_and_dynamic_content/liquid/l…
cf8c2ea 
…iquid_use_cases.md

Co-authored-by: Bre Fitzgerald <82903296+bre-fitzgerald@users.noreply.github.com>
@KellieHawks @bre-fitzgerald
Update _docs/_user_guide/personalization_and_dynamic_content/liquid/l…
d8e6c7e 
…iquid_use_cases.md

Co-authored-by: Bre Fitzgerald <82903296+bre-fitzgerald@users.noreply.github.com>
@KellieHawks
Update _docs/_user_guide/personalization_and_dynamic_content/liquid/l…
eda2f9f 
…iquid_use_cases.md
@KellieHawks @bre-fitzgerald
Update _docs/_api/api_campaigns.md
c29e8d9 
Co-authored-by: Bre Fitzgerald <82903296+bre-fitzgerald@users.noreply.github.com>
@KellieHawks @bre-fitzgerald
Update _docs/_user_guide/data_and_analytics/braze_currents.md
2d73c9c 
Co-authored-by: Bre Fitzgerald <82903296+bre-fitzgerald@users.noreply.github.com>
@KellieHawks @bre-fitzgerald
Update _docs/_user_guide/data_and_analytics/custom_data/custom_events.md
0953b25 
Co-authored-by: Bre Fitzgerald <82903296+bre-fitzgerald@users.noreply.github.com>
@KellieHawks @bre-fitzgerald
Update _docs/_user_guide/personalization_and_dynamic_content/liquid/l…
7150ea5 
…iquid_use_cases.md

Co-authored-by: Bre Fitzgerald <82903296+bre-fitzgerald@users.noreply.github.com>
@KellieHawks @bre-fitzgerald
Update _docs/_user_guide/data_and_analytics/custom_data/custom_events.md
da55fd9 
Co-authored-by: Bre Fitzgerald <82903296+bre-fitzgerald@users.noreply.github.com>
@KellieHawks @bre-fitzgerald
Update _docs/_user_guide/data_and_analytics/custom_data/custom_events.md
3c71edb 
Co-authored-by: Bre Fitzgerald <82903296+bre-fitzgerald@users.noreply.github.com>
@KellieHawks @bre-fitzgerald
Update _docs/_user_guide/data_and_analytics/custom_data/custom_events.md
2119773 
Co-authored-by: Bre Fitzgerald <82903296+bre-fitzgerald@users.noreply.github.com>
@bre-fitzgerald bre-fitzgerald merged commit 9720cd7 into develop Oct 21, 2022
@bre-fitzgerald bre-fitzgerald deleted the kh/csm branch October 21, 2022 15:08
@lydia-xie lydia-xie mentioned this pull request Oct 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lydia-xie lydia-xie lydia-xie approved these changes

@bre-fitzgerald bre-fitzgerald bre-fitzgerald approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KellieHawks @bre-fitzgerald @lydia-xie