Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix japanese scroll after changing language #4355

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Conversation

zzhaobraze
Copy link
Collaborator

Pull Request/Issue Resolution

Description of Change:

I'm changing..... (could be a link, a new image, a new section, etc.)... because...

Closes #ISSUE_NUMBER_HERE

Is this change associated with a Braze feature/product release?

  • Yes (Insert Feature Release Date Here)
  • No

✔️ Pull Request Checklist
  • Check that all links work.
  • Ensure you have completed our Contributors License Agreement.
  • Tag @timothy-kim and @KellieHawks as a reviewer when your work is done and ready to be reviewed for merge. Are you an internal product manager? Reference the internal reviewing chart to tag the appropriate reviewer.
  • Tag others as reviewers as necessary.
  • If you have modified any links, be sure to add redirects to assets > js > broken_redirect_list.js
⭐ Helpful Wiki Shortcuts
❗ ATTN: For PR Reviewers
  • Read our Reviewing a PR page for more on our reviewing suggestions.
  • Read our Previewing Documentation page to see how to check the deployment.
    • Preview all changes in the linked Vercel environment by clicking the preview link in the vercel-bot comment in your PR.
❗ ATTN: Internal Reviewing Chart
Work at Braze and not sure who to tag for review?
Before tagging @timothy-kim or @KellieHawks for a general review, reference the following chart to see if a specific product vertical/reviewer applies to your pull request.

Reviewer Product Vertical
@timothy-kim Data Infrastructure
Platform Infrastructure
Quality Infrastructure
@KellieHawks Internal Tools
Product Partnerships
SDKs
SMS
@bre-fitzgerald Channels
FIX
Intelligence
Reporting
SMB
@lydia-xie Email (Composition and Infrastructure)
Ingestion
Messaging

@vercel
Copy link

vercel bot commented Nov 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
braze-docs-en ✅ Ready (Inspect) Visit Preview Nov 4, 2022 at 1:39AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
braze-docs-fr ⬜️ Ignored (Inspect) Nov 4, 2022 at 1:39AM (UTC)

@cla-bot cla-bot bot added the cla-signed label Nov 4, 2022
@bre-fitzgerald
Copy link
Collaborator

Hey @zzhaobraze! Is it expected behavior that the language selector won't work in the vercel deployment? Changing it from English -> Japanese isn't doing anything in the preview.

@zzhaobraze
Copy link
Collaborator Author

Hey @zzhaobraze! Is it expected behavior that the language selector won't work in the vercel deployment? Changing it from English -> Japanese isn't doing anything in the preview.

yea the language translation only works when the domain is braze.com
that's why it's a little hard to test without deploying first.

@bre-fitzgerald bre-fitzgerald merged commit 7c972ff into develop Nov 4, 2022
@bre-fitzgerald bre-fitzgerald deleted the docs_jp_scroll branch November 4, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants