Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirects pointing at different locations for the same URL #4533

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

bre-fitzgerald
Copy link
Collaborator

Pull Request/Issue Resolution

Description of Change:

Fixing a few redirects that point /docs/frequency_capping_tag/ to conflicting places. All now point to /docs/user_guide/engagement_tools/campaigns/building_campaigns/rate-limiting/#frequency-capping

Closes #ISSUE_NUMBER_HERE

Is this change associated with a Braze feature/product release?

  • Yes (Insert Feature Release Date Here)
  • No

@vercel
Copy link

vercel bot commented Dec 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
braze-docs-en 🔄 Building (Inspect) Dec 13, 2022 at 4:12PM (UTC)
braze-docs-fr ✅ Ready (Inspect) Visit Preview Dec 13, 2022 at 4:12PM (UTC)

@scott-braze
Copy link
Contributor

I might be missing something, but the change here seems to be broken. If I visit https://www.braze.com/docs/frequency_capping_tag, then the result is a cryptic 404 page. If I visit https://www.braze.com/docs/hidden/private_betas/frequency_capping_tag, then I am redirected to https://www.braze.com/docs/user_guide/engagement_tools/campaigns/testing_and_more/rate-limiting?redirected=true#frequency-capping, which results in a Braze branded 404 message. If I delete the query string (?redirected=true), then it is the desired target: https://www.braze.com/docs/user_guide/engagement_tools/campaigns/testing_and_more/rate-limiting#frequency-capping

@bre-fitzgerald
Copy link
Collaborator Author

bre-fitzgerald commented Dec 14, 2022

@scott-braze, huh—thanks for flagging. Let me investigate and see what's up.

Edit: Fixed in #4543, thanks for catching this!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants