Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Flutter Docs to reference Swift SDK methods #4759

Merged
merged 6 commits into from
Feb 2, 2023

Conversation

nigelfaustino
Copy link
Contributor

Pull Request/Issue Resolution

Description of Change:

I'm changing the Flutter integration docs because it references outdated methods in the Obj-C SDK

Closes #ISSUE_NUMBER_HERE

Is this change associated with a Braze feature/product release?

  • [X ] Yes (Flutter SDK Version 3.0.0 Dec 6, 2022)
  • No

✔️ Pull Request Checklist
  • Check that you haven't removed any images (replacing an image with an updated one of the same name is fine), as this breaks the French site
  • Check that all links work.
  • Ensure you have completed our Contributors License Agreement.
  • Tag @timothy-kim and @KellieHawks as a reviewer when your work is done and ready to be reviewed for merge. Are you an internal product manager? Reference the internal reviewing chart to tag the appropriate reviewer.
  • Tag others as reviewers as necessary.
  • If you have modified any links, be sure to add redirects to assets > js > broken_redirect_list.js
⭐ Helpful Wiki Shortcuts
❗ ATTN: For PR Reviewers
  • Read our Reviewing a PR page for more on our reviewing suggestions.
  • Read our Previewing Documentation page to see how to check the deployment.
    • Preview all changes in the linked Vercel environment by clicking the preview link in the vercel-bot comment in your PR.
❗ ATTN: Internal Reviewing Chart
Work at Braze and not sure who to tag for review?
Before tagging @timothy-kim or @KellieHawks for a general review, reference the following chart to see if a specific product vertical/reviewer applies to your pull request.

Reviewer Product Vertical
@josh-mccrowell-braze Monolith Deployments
Quality Infrastructure
Platform Infrastructure
Datalake
SDKs
@KellieHawks Currents
Internal Tools
Product Partnerships
SMS
Customer Lifecycle, Identity and Permissions
@bre-fitzgerald Reporting
Intelligence
User Targeting
IAM
Channels
FIX
@lydia-xie Ingestion
Core Objects
Core Messaging
Messaging and Automation
Email (Composition and Infrastructure)

@vercel
Copy link

vercel bot commented Feb 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
braze-docs-en ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 1, 2023 at 11:29PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
braze-docs-fr ⬜️ Ignored (Inspect) Feb 1, 2023 at 11:29PM (UTC)

@cla-bot cla-bot bot added the cla-signed label Feb 1, 2023
@nigelfaustino nigelfaustino changed the title Update Update Flutter Docs to reference Swift SDK methods Feb 1, 2023
@nigelfaustino nigelfaustino marked this pull request as ready for review February 1, 2023 21:06
Copy link
Contributor

@hokstuff hokstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small wording nits - LGTM after!

nigelfaustino and others added 3 commits February 1, 2023 14:28
…tter_sdk_integration.md

Co-authored-by: Daniel Hok <4797040+hokstuff@users.noreply.github.com>
…tter_sdk_integration.md

Co-authored-by: Daniel Hok <4797040+hokstuff@users.noreply.github.com>
…tter_sdk_integration.md

Co-authored-by: Daniel Hok <4797040+hokstuff@users.noreply.github.com>
Comment on lines 78 to 79
// Enable logging of general SDK information (e.g. user changes, etc.)
configuration.logger.level = .info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo we can remove logger related lines for simplicity + less maintenance burden (same for obj-c example). They can visit the sample app or iOS docs to see something more fleshed out

@nigelfaustino nigelfaustino requested a review from a team February 1, 2023 23:25
Merge branch 'sdk3288-updateFlutterSwift' of github.com:braze-inc/braze-docs into sdk3288-updateFlutterSwift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants