Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BD-1887: Deliverability for Chinese Android devices #4762

Merged
merged 5 commits into from
Feb 7, 2023
Merged

BD-1887: Deliverability for Chinese Android devices #4762

merged 5 commits into from
Feb 7, 2023

Conversation

bre-fitzgerald
Copy link
Collaborator

Pull Request/Issue Resolution

Description of Change:

New push best practices article for deliverability nuances when targeting Android devices manufactured by Chinese OEMs.

Closes #BD-1887

Is this change associated with a Braze feature/product release?

  • Yes (Insert Feature Release Date Here)
  • No

@bre-fitzgerald bre-fitzgerald added the status: in progress Work in progress. label Feb 1, 2023
@vercel
Copy link

vercel bot commented Feb 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
braze-docs-en ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 6, 2023 at 6:28PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
braze-docs-fr ⬜️ Ignored (Inspect) Feb 6, 2023 at 6:28PM (UTC)

@cla-bot cla-bot bot added the cla-signed label Feb 1, 2023
@bre-fitzgerald bre-fitzgerald removed the status: in progress Work in progress. label Feb 3, 2023
ttsaiveerappan
ttsaiveerappan approved these changes Feb 6, 2023
View reviewed changes
Copy link

@ttsaiveerappan ttsaiveerappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lydia-xie
lydia-xie requested changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@lydia-xie lydia-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! caught 1 small thing

.../_user_guide/message_building_by_channel/push/best_practices/chinese_push_deliverability..md Outdated Show resolved Hide resolved
@bre-fitzgerald @lydia-xie
Update _docs/_user_guide/message_building_by_channel/push/best_practi…
cce65c6 
…ces/chinese_push_deliverability..md

Co-authored-by: Lydia Xie <87040416+lydia-xie@users.noreply.github.com>
@bre-fitzgerald @radixdev
Apply suggestions from dev review
18f02d5 
Co-authored-by: Julian Richard Contreras <julian.r.contreras@gmail.com>
@bre-fitzgerald bre-fitzgerald merged commit e7da523 into develop Feb 7, 2023
@bre-fitzgerald bre-fitzgerald deleted the BD-1887 branch February 7, 2023 17:32
@KellieHawks KellieHawks mentioned this pull request Feb 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttsaiveerappan ttsaiveerappan ttsaiveerappan approved these changes

@lydia-xie lydia-xie lydia-xie approved these changes

@radixdev radixdev radixdev approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bre-fitzgerald @radixdev @lydia-xie @ttsaiveerappan @josh-mccrowell-braze