Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live activities #4908

Merged
merged 29 commits into from
Feb 28, 2023
Merged

Live activities #4908

merged 29 commits into from
Feb 28, 2023

Conversation

josh-mccrowell-braze
Copy link
Collaborator

No description provided.

@josh-mccrowell-braze josh-mccrowell-braze added the status: in progress Work in progress. label Feb 25, 2023
@cla-bot cla-bot bot added the cla-signed label Feb 25, 2023
@vercel
Copy link

vercel bot commented Feb 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
braze-docs-en ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 28, 2023 at 10:09PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
braze-docs-fr ⬜️ Ignored (Inspect) Feb 28, 2023 at 10:09PM (UTC)

@josh-mccrowell-braze josh-mccrowell-braze added the status: do not merge Could mean research before "in progress" status, or do not merge yet. label Feb 25, 2023
jerielng
jerielng reviewed Feb 27, 2023
View reviewed changes
_docs/_developer_guide/platform_integration_guides/swift/live_activities.md Outdated
}
```

## Step 3: Updating a Live Activity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a note, steps 3-4 pertain to remotely updating/end Live Activities using push notifications, which is the main value of using Braze for Live Activities. There's a way to do this locally within the app, but since they own the Live Activity object themselves, they would just use Apple's ActivityKit APIs to do it themselves if they want to update/end it locally.

@josh-mccrowell-braze @jerielng
Apply suggestions from code review
616b491 
Co-authored-by: Jeriel Ng <jerielng@users.noreply.github.com>
josh-mccrowell-braze and others added 7 commits February 28, 2023 15:49
@josh-mccrowell-braze @KellieHawks
Apply suggestions from code review
56bb3aa 
Co-authored-by: KellieHawks <kellie.hawks@braze.com>
@josh-mccrowell-braze @KellieHawks
Apply suggestions from code review
084a197 
Co-authored-by: KellieHawks <kellie.hawks@braze.com>
@josh-mccrowell-braze @KellieHawks
Apply suggestions from code review
5feb7ed 
Co-authored-by: KellieHawks <kellie.hawks@braze.com>
@josh-mccrowell-braze @KellieHawks
Apply suggestions from code review
6988627 
Co-authored-by: KellieHawks <kellie.hawks@braze.com>
@josh-mccrowell-braze @KellieHawks
Update _docs/_developer_guide/platform_integration_guides/swift/live_…
eeef053 
…activities.md

Co-authored-by: KellieHawks <kellie.hawks@braze.com>
@josh-mccrowell-braze @KellieHawks
Update _docs/_developer_guide/platform_integration_guides/swift/live_…
f5caf81 
…activities.md

Co-authored-by: KellieHawks <kellie.hawks@braze.com>
@josh-mccrowell-braze
Apply suggestions from code review
ccc6b92
@josh-mccrowell-braze @KellieHawks
Update _docs/_developer_guide/platform_integration_guides/swift/live_…
a806b2d 
…activities.md

Co-authored-by: KellieHawks <kellie.hawks@braze.com>
@josh-mccrowell-braze josh-mccrowell-braze removed status: do not merge Could mean research before "in progress" status, or do not merge yet. status: in progress Work in progress. labels Feb 28, 2023
@bre-fitzgerald bre-fitzgerald self-requested a review February 28, 2023 22:22
@bre-fitzgerald bre-fitzgerald merged commit d29871b into develop Feb 28, 2023
@josh-mccrowell-braze josh-mccrowell-braze mentioned this pull request Feb 28, 2023
Merged
@KellieHawks KellieHawks deleted the live-activities branch March 21, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttsaiveerappan ttsaiveerappan ttsaiveerappan left review comments

@KellieHawks KellieHawks KellieHawks left review comments

@christorbraze christorbraze christorbraze left review comments

@jerielng jerielng jerielng left review comments

@bre-fitzgerald bre-fitzgerald bre-fitzgerald approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@josh-mccrowell-braze @davidbielik @jerielng @christorbraze @KellieHawks @bre-fitzgerald @ttsaiveerappan