Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in javascript example #4989

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Typo in javascript example #4989

merged 1 commit into from
Mar 8, 2023

Conversation

bujars
Copy link
Contributor

@bujars bujars commented Mar 8, 2023

Correcting the variable name to featureFlag

Pull Request/Issue Resolution

Description of Change:

I'm changing..... (could be a link, a new image, a new section, etc.)... because...

Closes #ISSUE_NUMBER_HERE

Is this change associated with a Braze feature/product release?

  • Yes (Insert Feature Release Date Here)
  • No

✔️ Pull Request Checklist
  • Check that you haven't removed any images (replacing an image with an updated one of the same name is fine), as this breaks the French site
  • Check that all links work.
  • Ensure you have completed our Contributors License Agreement.
  • Tag @timothy-kim and @KellieHawks as a reviewer when your work is done and ready to be reviewed for merge. Are you an internal product manager? Reference the internal reviewing chart to tag the appropriate reviewer.
  • Tag others as reviewers as necessary.
  • If you have modified any links, be sure to add redirects to assets > js > broken_redirect_list.js
⭐ Helpful Wiki Shortcuts
❗ ATTN: For PR Reviewers
  • Read our Reviewing a PR page for more on our reviewing suggestions.
  • Read our Previewing Documentation page to see how to check the deployment.
    • Preview all changes in the linked Vercel environment by clicking the preview link in the vercel-bot comment in your PR.
❗ ATTN: Internal Reviewing Chart
Work at Braze and not sure who to tag for review?
Before tagging @timothy-kim or @KellieHawks for a general review, reference the following chart to see if a specific product vertical/reviewer applies to your pull request.

Reviewer Product Vertical
@josh-mccrowell-braze Monolith Deployments
Quality Infrastructure
Platform Infrastructure
Datalake
SDKs
@KellieHawks Currents
Internal Tools
Product Partnerships
SMS
Customer Lifecycle, Identity and Permissions
@bre-fitzgerald Reporting
Intelligence
User Targeting
IAM
Channels
FIX
@lydia-xie Ingestion
Core Objects
Core Messaging
Messaging and Automation
Email (Composition and Infrastructure)

Correcting the variable name to featureFlag
@vercel
Copy link

vercel bot commented Mar 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
braze-docs-en ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 8, 2023 at 9:06PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
braze-docs-fr ⬜️ Ignored (Inspect) Mar 8, 2023 at 9:06PM (UTC)

@KellieHawks KellieHawks merged commit 935ce06 into develop Mar 8, 2023
@KellieHawks KellieHawks deleted the bujars-patch-1 branch March 8, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants