Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Section Revision #51

Merged
merged 5 commits into from
May 1, 2019
Merged

API Section Revision #51

merged 5 commits into from
May 1, 2019

Conversation

EmilyNecciai
Copy link
Contributor

Pull Request/Issue Resolution

Description of Change:

  • revising API section
    Reason for Change:
  • Audience corralling & topic categorization

PR Checklist

  • Ensure you have completed our CLA.
  • Tag @EmilyNecciai as a reviewer when the your work is done and ready to be reviewed for merge.
  • Consult the Docs Text Formatting Guide to be sure you're utilizing the proper markdown formatting.
  • Consult the Docs Writing Style Guide & Best Practices to be sure you're aligning with our voice and other style best practices.
  • Preview your deployed changes to confirm that none of your changes break production. Pay close attention to links and images.
  • Tag others as Reviewers as necessary.
  • If you have modified any links, be sure to add redirects to config/nginx.conf.erb.

@cla-bot cla-bot bot added the cla-signed label Apr 15, 2019
@appboyci appboyci temporarily deployed to braze-docs-staging-pr-51 April 15, 2019 19:52 Inactive
@EmilyNecciai EmilyNecciai marked this pull request as ready for review May 1, 2019 13:39
@EmilyNecciai EmilyNecciai requested a review from a team as a code owner May 1, 2019 13:39
@EmilyNecciai EmilyNecciai requested a review from zzhaobraze May 1, 2019 13:42
@appboyci appboyci temporarily deployed to braze-docs-staging-pr-51 May 1, 2019 14:04 Inactive
zzhaobraze
zzhaobraze approved these changes May 1, 2019
View reviewed changes
Copy link
Collaborator

@zzhaobraze zzhaobraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@EmilyNecciai EmilyNecciai merged commit 14f2c3a into develop May 1, 2019
@EmilyNecciai EmilyNecciai deleted the en/api-section branch May 1, 2019 14:19
@EmilyNecciai EmilyNecciai mentioned this pull request May 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzhaobraze zzhaobraze zzhaobraze approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmilyNecciai @zzhaobraze @appboyci