FF-react #5164
Merged
FF-react #5164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
wesleyorbin
approved these changes
Mar 30, 2023
jerielng
reviewed
Apr 3, 2023
| {% tab React Native %} | ||
| ```javascript | ||
| // string properties | ||
| const stringProperty = await braze.getFeatureFlagStringProperty("color"); |
There was a problem hiding this comment.
The property methods are supposed to take in two params: ("flag-id", "property-key");
Suggested change
| const stringProperty = await braze.getFeatureFlagStringProperty("color"); | |
| const stringProperty = await braze.getFeatureFlagStringProperty("my_flag", "color"); |
Co-authored-by: Jeriel Ng <jerielng@users.noreply.github.com>
jerielng
reviewed
Apr 3, 2023
jerielng
reviewed
Apr 3, 2023
jerielng
reviewed
Apr 3, 2023
| @@ -138,6 +138,16 @@ if (featureFlag.enabled) { | |||
| } | |||
| ``` | |||
| {% endtab %} | |||
| {% tab React Native %} | |||
| ```javascript | |||
| const featureFlag = await braze.getFeatureFlag("expanded_user_profile"); | |||
There was a problem hiding this comment.
Regarding your note about Braze vs braze, I know in the sample app we have it as Braze, but I'm not sure if that's a TS convention. If it were Swift, we would lowercase it unless it was a static reference. @wesleyorbin do you have any thoughts?
There was a problem hiding this comment.
yea, in theory it could be:
import David from "braze-react-native-sdk"
So probably doesn't matter that much, but i'll change it to Braze to match the sample app.
Co-authored-by: Jeriel Ng <jerielng@users.noreply.github.com>
jerielng
reviewed
Apr 3, 2023
Co-authored-by: Jeriel Ng <jerielng@users.noreply.github.com>
jerielng
approved these changes
Apr 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code samples for react FF