Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-3595] Add BrazeConfig to disable location collection docs #5165

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

@cla-bot cla-bot bot added the cla-signed label Mar 30, 2023
@vercel
Copy link

vercel bot commented Mar 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
braze-docs-en ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 30, 2023 at 7:50PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
braze-docs-fr ⬜️ Ignored (Inspect) Mar 30, 2023 at 7:50PM (UTC)

@Bucimis Bucimis changed the title Add BrazeConfig to disable location collection docs [SDK-3595] Add BrazeConfig to disable location collection docs Mar 30, 2023
@bryanlogan
Copy link
Contributor

Would it be helpful to include that they could also not include android-sdk-location ?

@Bucimis
Copy link
Contributor Author

Bucimis commented Mar 30, 2023

@bryanlogan interesting point, I'd say since the point of this PR is to add the runtime config (which android-sdk-location is not), we ship this narrow change now and separately evaluate holistically how we want to recommend people to turn on and off location functionality at compile time. It's possible we may want e.g. the presence of android-sdk-location code to replace com_braze_enable_location_collection completely, with BrazeConfig as a runtime override.

@josh-mccrowell-braze josh-mccrowell-braze merged commit ef82de2 into develop Mar 31, 2023
@josh-mccrowell-braze josh-mccrowell-braze deleted the SDK-3595 branch March 31, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants