Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom_events.md #5412

Merged
merged 1 commit into from
May 12, 2023
Merged

Update custom_events.md #5412

merged 1 commit into from
May 12, 2023

Conversation

ipavan
Copy link
Contributor

@ipavan ipavan commented May 12, 2023

fix to the code view, changing a semi-colon to a colon

Pull Request/Issue Resolution

Description of Change:

Fixing one bit in the code view, changing a semi-colon to a colon

Closes #ISSUE_NUMBER_HERE

Is this change associated with a Braze feature/product release?

  • Yes (Insert Feature Release Date Here)
  • No

✔️ Pull Request Checklist
  • Check that you haven't removed any images (replacing an image with an updated one of the same name is fine), as this breaks the French site
  • Check that all links work.
  • Ensure you have completed our Contributors License Agreement.
  • Tag @josh-mccrowell-braze and @KellieHawks as a reviewer when your work is done and ready to be reviewed for merge. Are you an internal product manager? Reference the internal reviewing chart to tag the appropriate reviewer.
  • Tag others as reviewers as necessary.
  • If you have modified any links, be sure to add redirects to assets > js > broken_redirect_list.js
⭐ Helpful Wiki Shortcuts
❗ ATTN: For PR Reviewers
  • Read our Reviewing a PR page for more on our reviewing suggestions.
  • Read our Previewing Documentation page to see how to check the deployment.
    • Preview all changes in the linked Vercel environment by clicking the preview link in the vercel-bot comment in your PR.
❗ ATTN: Internal Reviewing Chart
Work at Braze and not sure who to tag for review?
Before tagging @josh-mccrowell-braze or @KellieHawks for a general review, reference the following chart to see if a specific product vertical/reviewer applies to your pull request.

Reviewer Product Vertical
@josh-mccrowell-braze Monolith Deployments
Quality Infrastructure
Platform Infrastructure
Datalake
SDKs
@KellieHawks Currents
Internal Tools
Product Partnerships
SMS
Customer Lifecycle, Identity and Permissions
@bre-fitzgerald Reporting
Intelligence
User Targeting
IAM
Channels
FIX
@lydia-xie Ingestion
Core Objects
Core Messaging
Messaging and Automation
Email (Composition and Infrastructure)

fix to the code view, changing a semi-colon to a colon
@vercel
Copy link

vercel bot commented May 12, 2023

@ipavan is attempting to deploy a commit to the Braze Team on Vercel.

A member of the Team first needs to authorize it.

@cla-bot cla-bot bot added the cla-signed label May 12, 2023
@ipavan
Copy link
Contributor Author

ipavan commented May 12, 2023

@KellieHawks

@KellieHawks KellieHawks merged commit 3b365db into braze-inc:develop May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants