Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated GCM web push setup instructions pending GCM's deletion by Google. #67

Merged
merged 2 commits into from
Apr 25, 2019

Conversation

froodian
Copy link
Contributor

Pull Request/Issue Resolution

Description of Change:

These steps (setting up a GCM/FCM project, introducing manifest.json with gcm_sender_id) were only required for older versions of Chrome which rely-upon GCM. Google's recommended integration path since 2016 is to use VAPID authentication instead (which we support transparently, without any user setup required). So, with GCM going away at the end of May, so too should our recommendation of using this legacy setup methodology go away.

Reason for Change:

Closes #ISSUE_NUMBER_HERE



PR Checklist

  • Ensure you have completed our CLA.
  • Tag @EmilyNecciai as a reviewer when the your work is done and ready to be reviewed for merge.
  • Consult the Docs Text Formatting Guide to be sure you're utilizing the proper markdown formatting.
  • Consult the Docs Writing Style Guide & Best Practices to be sure you're aligning with our voice and other style best practices.
  • Preview your deployed changes to confirm that none of your changes break production. Pay close attention to links and images.
  • Tag others as Reviewers as necessary.
  • If you have modified any links, be sure to add redirects to config/nginx.conf.erb.


Copy link
Contributor

@dkim32 dkim32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@EmilyNecciai EmilyNecciai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@EmilyNecciai EmilyNecciai merged commit 2bf5dc7 into develop Apr 25, 2019
@EmilyNecciai EmilyNecciai deleted the remove-web-push-gcm-setup branch April 25, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants