-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-4592] [BD-2646] Cordova - Add a comprehensive list of configurations for Android and iOS #6939
Conversation
Hello! I know this PR is still a draft. Just tagging in Isaiah so that he can track its progress and be tagged in when you need a reviewer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wooo thanks for improving our (often neglected 😅) wrapper docs! 💯
Note: I'm working on some rewrites but running some questions by @vanessaland. I think the iOS and Android doc are extremely similar and could be easily merged together with minimal work. |
Hey @vanessaland , I made a significant amount of edits here based on our discussion (although not all the ones we'd like to implement that i'll save for a future ticket). I still need to set up redirects for the old files that are renamed/merged/removed, but in the meantime, do you mind checking out my changes and leaving feedback if applicable? Thanks! Let me know if you have any questions! |
Hey @internetisaiah ! Thank you so much for making these changes, the new formatting and flow is great! I just added a few small changes in the most recent commit. (Mainly small changes with the code examples and links). Let me know what you think, but everything looks good on my end 👍🏼 Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request/Issue Resolution
Description of Change:
I'm updating the documentation for configuring Cordova Android and Cordova iOS applications because we are adding new support for several configurations on the Cordova SDK. I also added a comprehensive list to describe each of the configurations.
I also made a few changes to the docs to make sure the Android and iOS pages are similar and include the same amount of information.
Closes:
Is this change associated with a Braze feature/product release?
✔️ Pull Request Checklist
assets
>js
>broken_redirect_list.js
⭐ Helpful Wiki Shortcuts
❗ ATTN: For PR Reviewers
❗ ATTN: Internal Reviewing Chart
Work at Braze and not sure who to tag for review?
Before tagging @josh-mccrowell-braze or @internetisaiah for a general review, reference the following chart to see if a specific product vertical/reviewer applies to your pull request.
Quality Infrastructure
Platform Infrastructure
Datalake
SDKs
Currents
Technology partners
Channels
In-App Messages
Channels
Frontend Infrastructure & Experience (FIX)
Core Objects
Core Messaging
Messaging Experience
Message Components
Email (Composition and Infrastructure) (tag @rachel-feinberg for Liquid use cases)
SMS
User Targeting
Reporting