Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-4592] [BD-2646] Cordova - Add a comprehensive list of configurations for Android and iOS #6939

Merged
merged 10 commits into from
Mar 14, 2024

Conversation

vanessaland
Copy link
Contributor

@vanessaland vanessaland commented Feb 21, 2024

Pull Request/Issue Resolution

Description of Change:

I'm updating the documentation for configuring Cordova Android and Cordova iOS applications because we are adding new support for several configurations on the Cordova SDK. I also added a comprehensive list to describe each of the configurations.

I also made a few changes to the docs to make sure the Android and iOS pages are similar and include the same amount of information.

Closes:

Is this change associated with a Braze feature/product release?


✔️ Pull Request Checklist
  • Check that you haven't removed any images (replacing an image with an updated one of the same name is fine), as this breaks the French site
  • Check that all links work.
  • Ensure you have completed our Contributors License Agreement.
  • Tag @josh-mccrowell-braze and @internetisaiah as a reviewer when your work is done and ready to be reviewed for merge. Are you an internal product manager? Reference the internal reviewing chart to tag the appropriate reviewer.
  • If the documentation involves a 1) paid SKU, 2) a third party, 3) SMS, 4) AI, or 5) privacy, ensure that Maria Maldonado on the Legal team has signed off.
  • Tag others as reviewers as necessary.
  • If you have modified any links, be sure to add redirects to assets > js > broken_redirect_list.js
⭐ Helpful Wiki Shortcuts
❗ ATTN: For PR Reviewers
  • Read our Reviewing a PR page for more on our reviewing suggestions.
  • Read our Previewing Documentation page to see how to check the deployment.
    • Preview all changes in the linked Vercel environment by clicking the preview link in the vercel-bot comment in your PR.
❗ ATTN: Internal Reviewing Chart
Work at Braze and not sure who to tag for review?
Before tagging @josh-mccrowell-braze or @internetisaiah for a general review, reference the following chart to see if a specific product vertical/reviewer applies to your pull request.

Reviewer Product Vertical
@josh-mccrowell-braze Monolith Deployments
Quality Infrastructure
Platform Infrastructure
Datalake
SDKs
Currents
@internetisaiah Developer Guide
Technology partners
Channels
@bre-fitzgerald Intelligence
In-App Messages
Channels
Frontend Infrastructure & Experience (FIX)
@lydia-xie Ingestion
Core Objects
Core Messaging
Messaging Experience
Message Components
Email (Composition and Infrastructure) (tag @rachel-feinberg for Liquid use cases)
@rachel-feinberg Customer Lifecycle, Identity and Permissions
SMS
User Targeting
Reporting

@cla-bot cla-bot bot added the cla-signed label Feb 21, 2024
@vanessaland vanessaland added status: do not merge Could mean research before "in progress" status, or do not merge yet. and removed cla-signed labels Feb 21, 2024
@vanessaland vanessaland changed the title add configurations for Android page [SDK-4592] Cordova - Add a comprehensive list of configurations for Android and iOS Feb 21, 2024
@josh-mccrowell-braze
Copy link
Collaborator

Hello! I know this PR is still a draft. Just tagging in Isaiah so that he can track its progress and be tagged in when you need a reviewer.

@vanessaland vanessaland marked this pull request as ready for review February 22, 2024 21:03
@vanessaland vanessaland requested a review from a team February 22, 2024 21:03
Copy link
Contributor

@hokstuff hokstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wooo thanks for improving our (often neglected 😅) wrapper docs! 💯

@internetisaiah
Copy link
Contributor

Note: I'm working on some rewrites but running some questions by @vanessaland. I think the iOS and Android doc are extremely similar and could be easily merged together with minimal work.

@internetisaiah
Copy link
Contributor

Hey @vanessaland , I made a significant amount of edits here based on our discussion (although not all the ones we'd like to implement that i'll save for a future ticket).

I still need to set up redirects for the old files that are renamed/merged/removed, but in the meantime, do you mind checking out my changes and leaving feedback if applicable?

Thanks! Let me know if you have any questions!

@vanessaland
Copy link
Contributor Author

Hey @internetisaiah ! Thank you so much for making these changes, the new formatting and flow is great!

I just added a few small changes in the most recent commit. (Mainly small changes with the code examples and links).

Let me know what you think, but everything looks good on my end 👍🏼 Thanks again!

@vanessaland vanessaland removed the status: do not merge Could mean research before "in progress" status, or do not merge yet. label Mar 13, 2024
Copy link
Contributor

@internetisaiah internetisaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@internetisaiah internetisaiah merged commit f7b8b82 into develop Mar 14, 2024
2 checks passed
@internetisaiah internetisaiah deleted the SDK-4592 branch March 14, 2024 17:56
@internetisaiah internetisaiah mentioned this pull request Apr 2, 2024
20 tasks
@internetisaiah internetisaiah changed the title [SDK-4592] Cordova - Add a comprehensive list of configurations for Android and iOS [SDK-4592] [BD-2646] Cordova - Add a comprehensive list of configurations for Android and iOS Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants