Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-4760] Update Unity docs around release assets #6973

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

hokstuff
Copy link
Contributor

Pull Request/Issue Resolution

Description of Change:

I'm changing..... (could be a link, a new image, a new section, etc.)... because...

As of 4.0.0, our Unity release assets no longer have a Appboy-nodeps.unitypackage because instead you'd download Appboy.unitypackage. If you want to import SDWebImage, you can toggle in the Unity UI to opt-in and import SDWebImage

(You can compare the current 3 assets attached to the release vs the 4 assets in 3.x and before)

https://jira.braze.com/browse/SDK-4760

Is this change associated with a Braze feature/product release?

  • Yes (Insert Feature Release Date Here)
  • No

✔️ Pull Request Checklist
  • Check that you haven't removed any images (replacing an image with an updated one of the same name is fine), as this breaks the French site
  • Check that all links work.
  • Ensure you have completed our Contributors License Agreement.
  • Tag @josh-mccrowell-braze and @internetisaiah as a reviewer when your work is done and ready to be reviewed for merge. Are you an internal product manager? Reference the internal reviewing chart to tag the appropriate reviewer.
  • If the documentation involves a 1) paid SKU, 2) a third party, 3) SMS, 4) AI, or 5) privacy, ensure that Maria Maldonado on the Legal team has signed off.
  • Tag others as reviewers as necessary.
  • If you have modified any links, be sure to add redirects to assets > js > broken_redirect_list.js
⭐ Helpful Wiki Shortcuts
❗ ATTN: For PR Reviewers
  • Read our Reviewing a PR page for more on our reviewing suggestions.
  • Read our Previewing Documentation page to see how to check the deployment.
    • Preview all changes in the linked Vercel environment by clicking the preview link in the vercel-bot comment in your PR.
❗ ATTN: Internal Reviewing Chart
Work at Braze and not sure who to tag for review?
Before tagging @josh-mccrowell-braze or @internetisaiah for a general review, reference the following chart to see if a specific product vertical/reviewer applies to your pull request.

Reviewer Product Vertical
@josh-mccrowell-braze Monolith Deployments
Quality Infrastructure
Platform Infrastructure
Datalake
SDKs
Currents
@internetisaiah Developer Guide
Technology partners
Channels
@bre-fitzgerald Intelligence
In-App Messages
Channels
Frontend Infrastructure & Experience (FIX)
@lydia-xie Ingestion
Core Objects
Core Messaging
Messaging Experience
Message Components
Email (Composition and Infrastructure) (tag @rachel-feinberg for Liquid use cases)
@rachel-feinberg Customer Lifecycle, Identity and Permissions
SMS
User Targeting
Reporting

@hokstuff hokstuff requested a review from a team February 28, 2024 21:32
@cla-bot cla-bot bot added the cla-signed label Feb 28, 2024

**iOS**: To see if you require the [SDWebImage][unity-1] dependency for your iOS project, visit the [iOS in-app message documentation][unity-4].<br>
**Android**: As of Unity 2.6.0, the bundled Braze Android SDK artifact requires [AndroidX][unity-3] dependencies. If you were previously using a `jetified unitypackage`, then you can safely transition to the corresponding `unitypackage`.
**Android**: As of Unity 2.6.0, the bundled Braze Android SDK artifact requires [AndroidX][unity-3] dependencies. If you were previously using a `jetified unitypackage`, then you can safely transition to the corresponding `unitypackage`.

## Step 2: Import the package

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question for docs team: What is the process for updating the complementary French docs (or other languages)?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hokstuff Good question about the French docs! The Localization team has downstream workflows. We don't need to/shouldn't update the French docs, as it will be handled separately.

@hokstuff hokstuff marked this pull request as ready for review February 29, 2024 20:28
@josh-mccrowell-braze
Copy link
Collaborator

Hey hey @hokstuff : This looks good on my end. Are these changes ready to be rolled out?

@hokstuff
Copy link
Contributor Author

@josh-mccrowell-braze Yes it is ready to be merged and released!

@josh-mccrowell-braze josh-mccrowell-braze merged commit 2af9686 into develop Mar 11, 2024
2 checks passed
@josh-mccrowell-braze josh-mccrowell-braze deleted the SDK-4760-unityAssetsDocs branch March 11, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants