Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jampp Docs #72

Merged
merged 2 commits into from
Apr 25, 2019
Merged

Jampp Docs #72

merged 2 commits into from
Apr 25, 2019

Conversation

EmilyNecciai
Copy link
Contributor

Pull Request/Issue Resolution

Description of Change:

Reason for Change:

Closes #ISSUE_NUMBER_HERE

PR Checklist

  • Ensure you have completed our CLA.
  • Tag @EmilyNecciai as a reviewer when the your work is done and ready to be reviewed for merge.
  • Consult the Docs Text Formatting Guide to be sure you're utilizing the proper markdown formatting.
  • Consult the Docs Writing Style Guide & Best Practices to be sure you're aligning with our voice and other style best practices.
  • Preview your deployed changes to confirm that none of your changes break production. Pay close attention to links and images.
  • Tag others as Reviewers as necessary.
  • If you have modified any links, be sure to add redirects to config/nginx.conf.erb.

@EmilyNecciai EmilyNecciai requested a review from dkim32 April 24, 2019 14:34
@EmilyNecciai EmilyNecciai requested a review from a team as a code owner April 24, 2019 14:34
@cla-bot cla-bot bot added the cla-signed label Apr 24, 2019
@appboyci appboyci temporarily deployed to braze-docs-staging-pr-72 April 24, 2019 14:35 Inactive
dkim32
dkim32 reviewed Apr 24, 2019
View reviewed changes
_docs/_partners/technology_partners/advertising_technologies/retargeting/jampp.md Outdated

Requirement | Source | Description
--------------|--------| -----
Android or iOS App ID | Braze | Your unique application identifier (i.e. “012345678”).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are two different formats. i'd probably recommend adding these as separate lines.
Screen Shot 2019-04-24 at 12 54 47 PM

dkim32
dkim32 requested changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@dkim32 dkim32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just an updated related to the requirements for the Android/iOS app id but otherwise looks great!

zzhaobraze
zzhaobraze approved these changes Apr 25, 2019
View reviewed changes
Copy link
Collaborator

@zzhaobraze zzhaobraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

dkim32
dkim32 approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@dkim32 dkim32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for the update!

@EmilyNecciai EmilyNecciai merged commit 629bfc1 into develop Apr 25, 2019
@EmilyNecciai EmilyNecciai deleted the en/jampp branch April 25, 2019 20:07
@EmilyNecciai EmilyNecciai mentioned this pull request Apr 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzhaobraze zzhaobraze zzhaobraze approved these changes

@dkim32 dkim32 dkim32 approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EmilyNecciai @dkim32 @zzhaobraze @appboyci