Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIP-841] Fix documentation for SCIM app group permission objects. #7345

Merged
merged 1 commit into from
May 15, 2024

Conversation

felipegoraro-braze
Copy link
Contributor

@felipegoraro-braze felipegoraro-braze commented May 14, 2024

Pull Request/Issue Resolution

Description of Change:

Fix for a typo on the scim API appendix which does not match expected API parameter names

Is this change associated with a Braze feature/product release?

  • Yes (Insert Feature Release Date Here)
  • No

✔️ Pull Request Checklist
  • Check that you haven't removed any images (replacing an image with an updated one of the same name is fine), as this breaks the French site
  • Check that all links work.
  • Ensure you have completed our Contributors License Agreement.
  • Tag @josh-mccrowell-braze and @internetisaiah as a reviewer when your work is done and ready to be reviewed for merge. Are you an internal product manager? Reference the internal reviewing chart to tag the appropriate reviewer.
  • If the documentation involves a 1) paid SKU, 2) a third party, 3) SMS, 4) AI, or 5) privacy, ensure that Ana Teresa Serafino on the Legal team has signed off.
  • Tag others as reviewers as necessary.
  • If you have modified any links, be sure to add redirects to assets > js > broken_redirect_list.js
⭐ Helpful Wiki Shortcuts
❗ ATTN: For PR Reviewers
  • Read our Reviewing a PR page for more on our reviewing suggestions.
  • Read our Previewing Documentation page to see how to check the deployment.
    • Preview all changes in the linked Vercel environment by clicking the preview link in the vercel-bot comment in your PR.
❗ ATTN: Internal Reviewing Chart
Work at Braze and not sure who to tag for review?
Before tagging @josh-mccrowell-braze or @internetisaiah for a general review, reference the following chart to see if a specific product vertical/reviewer applies to your pull request.

Reviewer Product Vertical
@josh-mccrowell-braze Monolith Deployments
Quality Infrastructure
Platform Infrastructure
Datalake
SDKs
Currents
@internetisaiah Developer Guide
Technology partners
Channels
@bre-fitzgerald Intelligence
In-App Messages
Channels
Frontend Infrastructure & Experience (FIX)
@lydia-xie Ingestion
Core Objects
Core Messaging
Messaging Experience
Message Components
Email (Composition and Infrastructure) (tag @rachel-feinberg for Liquid use cases)
@rachel-feinberg Customer Lifecycle, Identity and Permissions
SMS
User Targeting
Reporting

Copy link

cla-bot bot commented May 14, 2024

We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please fill out the information here. To re-call the cla-bot, comment @cla-bot check.

@josh-mccrowell-braze
Copy link
Collaborator

@cla-bot check

Copy link

cla-bot bot commented May 14, 2024

We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please fill out the information here. To re-call the cla-bot, comment @cla-bot check.

Copy link

cla-bot bot commented May 14, 2024

The cla-bot has been summoned, and re-checked this pull request!

@josh-mccrowell-braze
Copy link
Collaborator

Hi @felipegoraro-braze

Thanks so much for raising this issue! Happy to merge this in for you, but we do require contributors to contributor license agreement. Once you've signed it, let me know. I can then merge your changes in.

Appreciate it!

@felipegoraro-braze felipegoraro-braze marked this pull request as ready for review May 15, 2024 19:50
@felipegoraro-braze
Copy link
Contributor Author

Hi @felipegoraro-braze

Thanks so much for raising this issue! Happy to merge this in for you, but we do require contributors to contributor license agreement. Once you've signed it, let me know. I can then merge your changes in.

Appreciate it!

No problem, I signed the agreement. Thank you!

@josh-mccrowell-braze
Copy link
Collaborator

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label May 15, 2024
Copy link

cla-bot bot commented May 15, 2024

The cla-bot has been summoned, and re-checked this pull request!

@josh-mccrowell-braze josh-mccrowell-braze merged commit 0915636 into develop May 15, 2024
2 checks passed
@josh-mccrowell-braze josh-mccrowell-braze deleted the clip_841 branch May 15, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants