Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifying updates to Cordova push documentation #7451

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

jerielng
Copy link
Contributor

@jerielng jerielng commented Jun 3, 2024

Pull Request/Issue Resolution

Description of Change:

Updating the Cordova push docs to be clearer. We got some confusion around the necessary integration steps. Clarifying:

  1. Basic push is automatically enabled for both iOS and Android but can be disabled via XML configurations
  2. If people want to further customize their native push, they can disable the XML configurations and implement them following the native SDK instructions.
  3. Android rich push and push stories are available out of the box but iOS can be configured via the steps detailed on this page.

Closes #ISSUE_NUMBER_HERE

Is this change associated with a Braze feature/product release?

  • Yes (Insert Feature Release Date Here)
  • No

✔️ Pull Request Checklist
  • Check that you haven't removed any images (replacing an image with an updated one of the same name is fine), as this breaks the French site
  • Check that all links work.
  • Ensure you have completed our Contributors License Agreement.
  • Tag @josh-mccrowell-braze and @internetisaiah as a reviewer when your work is done and ready to be reviewed for merge. Are you an internal product manager? Reference the internal reviewing chart to tag the appropriate reviewer.
  • If the documentation involves a 1) paid SKU, 2) a third party, 3) SMS, 4) AI, or 5) privacy, ensure that Ana Teresa Serafino on the Legal team has signed off.
  • Tag others as reviewers as necessary.
  • If you have modified any links, be sure to add redirects to assets > js > broken_redirect_list.js
⭐ Helpful Wiki Shortcuts
❗ ATTN: For PR Reviewers
  • Read our Reviewing a PR page for more on our reviewing suggestions.
  • Read our Previewing Documentation page to see how to check the deployment.
    • Preview all changes in the linked Vercel environment by clicking the preview link in the vercel-bot comment in your PR.
❗ ATTN: Internal Reviewing Chart
Work at Braze and not sure who to tag for review?
Before tagging @josh-mccrowell-braze or @internetisaiah for a general review, reference the following chart to see if a specific product vertical/reviewer applies to your pull request.

Reviewer Product Vertical
@josh-mccrowell-braze Monolith Deployments
Quality Infrastructure
Platform Infrastructure
Datalake
SDKs
Currents
@internetisaiah Developer Guide
Technology partners
Channels
@bre-fitzgerald Intelligence
In-App Messages
Channels
Frontend Infrastructure & Experience (FIX)
@lydia-xie Ingestion
Core Objects
Core Messaging
Messaging Experience
Message Components
Email (Composition and Infrastructure) (tag @rachel-feinberg for Liquid use cases)
@rachel-feinberg Customer Lifecycle, Identity and Permissions
SMS
User Targeting
Reporting

@cla-bot cla-bot bot added the cla-signed label Jun 3, 2024
@internetisaiah
Copy link
Contributor

Hey @jerielng , is this one ready for a TW review?

@internetisaiah internetisaiah self-assigned this Jun 3, 2024
@jerielng
Copy link
Contributor Author

jerielng commented Jun 3, 2024

Hey @jerielng , is this one ready for a TW review?

Yep it is!

@internetisaiah internetisaiah merged commit a19154b into develop Jun 3, 2024
3 checks passed
@internetisaiah internetisaiah deleted the cordova-push-docs branch June 3, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants