-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating PR template #7480
Updating PR template #7480
Conversation
Adding a note about a commonly-viewed issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! left 2 small suggestions 🫡
Co-authored-by: Lydia Xie <87040416+lydia-xie@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Left a small comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Love this change 😍 Left one suggestion for a bit of clarification, otherwise LGTM
Co-authored-by: Bre Fitzgerald <82903296+bre-fitzgerald@users.noreply.github.com>
Pull Request/Issue Resolution
Description of Change:
Updating our current PR template for the Braze Docs repository. Feel free to add comments and suggestions. My goal is to cut down the noise on the PR templates to increase the readability and usability for internal and external contributors. Open to any/all feedback!
Is this change associated with a Braze feature/product release?
✔️ Pull Request Checklist
assets
>js
>broken_redirect_list.js
⭐ Helpful Wiki Shortcuts
❗ ATTN: For PR Reviewers
❗ ATTN: Internal Reviewing Chart
Work at Braze and not sure who to tag for review?
Before tagging @josh-mccrowell-braze or @internetisaiah for a general review, reference the following chart to see if a specific product vertical/reviewer applies to your pull request.
Quality Infrastructure
Platform Infrastructure
Datalake
SDKs
Currents
Technology partners
Channels
In-App Messages
Channels
Frontend Infrastructure & Experience (FIX)
Core Objects
Core Messaging
Messaging Experience
Message Components
Email (Composition and Infrastructure) (tag @rachel-feinberg for Liquid use cases)
SMS
User Targeting
Reporting