Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundle ID configurations for Expo app extensions #7552

Merged
merged 8 commits into from
Jul 1, 2024

Conversation

jerielng
Copy link
Contributor

Pull Request/Issue Resolution

Description of Change:

Adds integration instructions for using Expo iOS app extensions (rich push and push stories) with Expo Application Services.

Is this change associated with a Braze feature/product release?

  • Yes (Insert Feature Release Date Here)
  • No

✔️ Pull Request Checklist
  • Check that you haven't removed any images (replacing an image with an updated one of the same name is fine), as this breaks the French site
  • Check that all links work.
  • Ensure you have completed our Contributors License Agreement.
  • Tag @josh-mccrowell-braze and @internetisaiah as a reviewer when your work is done and ready to be reviewed for merge. Are you an internal product manager? Reference the internal reviewing chart to tag the appropriate reviewer.
  • If the documentation involves a 1) paid SKU, 2) a third party, 3) SMS, 4) AI, or 5) privacy, ensure that Ana Teresa Serafino on the Legal team has signed off.
  • Tag others as reviewers as necessary.
  • If you have modified any links, be sure to add redirects to assets > js > broken_redirect_list.js
⭐ Helpful Wiki Shortcuts
❗ ATTN: For PR Reviewers
  • Read our Reviewing a PR page for more on our reviewing suggestions.
  • Read our Previewing Documentation page to see how to check the deployment.
    • Preview all changes in the linked Vercel environment by clicking the preview link in the vercel-bot comment in your PR.
❗ ATTN: Internal Reviewing Chart
Work at Braze and not sure who to tag for review?
Before tagging @josh-mccrowell-braze or @internetisaiah for a general review, reference the following chart to see if a specific product vertical/reviewer applies to your pull request.

Reviewer Product Vertical
@josh-mccrowell-braze Monolith Deployments
Quality Infrastructure
Platform Infrastructure
Datalake
SDKs
Currents
@internetisaiah Developer Guide
Technology partners
Channels
@bre-fitzgerald Intelligence
In-App Messages
Channels
Frontend Infrastructure & Experience (FIX)
@lydia-xie Ingestion
Core Objects
Core Messaging
Messaging Experience
Message Components
Email (Composition and Infrastructure) (tag @rachel-feinberg for Liquid use cases)
@rachel-feinberg Customer Lifecycle, Identity and Permissions
SMS
User Targeting
Reporting

@cla-bot cla-bot bot added the cla-signed label Jun 20, 2024
…e/push_notifications.md

Co-authored-by: Daniel Hok <4797040+hokstuff@users.noreply.github.com>
@jerielng jerielng requested review from a team and internetisaiah June 20, 2024 20:57
@jerielng jerielng marked this pull request as ready for review June 21, 2024 15:20
@internetisaiah
Copy link
Contributor

Hey @jerielng , is this one ready for a tech writer review now? Or does it need to be checked by the wrappers team first?

@jerielng
Copy link
Contributor Author

Hey @jerielng , is this one ready for a tech writer review now? Or does it need to be checked by the wrappers team first?

Thanks for checking in @internetisaiah! I think ideally we'll probably need one more set of eyes from the SDKs team and then it should be good for a tech writer review.

Copy link
Contributor

@vanessaland vanessaland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just a small note about the link for #declaring-bundle-identifiers-for-app-extensions

@jerielng
Copy link
Contributor Author

@internetisaiah Should be ready now!

Copy link
Collaborator

@josh-mccrowell-braze josh-mccrowell-braze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@josh-mccrowell-braze josh-mccrowell-braze merged commit 6f5fe10 into develop Jul 1, 2024
3 checks passed
@josh-mccrowell-braze josh-mccrowell-braze deleted the feature/eas-configs branch July 1, 2024 15:53
@lydia-xie lydia-xie mentioned this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants