Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partners: LiveRamp + Snowflake + Braze #7563

Merged
merged 16 commits into from
Aug 5, 2024

Conversation

internetisaiah
Copy link
Contributor

Pull Request/Issue Resolution

Description of Change:

Partners: LiveRamp + Snowflake + Braze. Original doc from partner here. First-round Braze edits here.

Is this change associated with a Braze feature/product release?

  • Yes (Insert Feature Release Date Here)
  • No

✔️ Pull Request Checklist
  • Check that you haven't removed any images (replacing an image with an updated one of the same name is fine), as this breaks the French site
  • Check that all links work.
  • Ensure you have completed our Contributors License Agreement.
  • Tag @josh-mccrowell-braze and @internetisaiah as a reviewer when your work is done and ready to be reviewed for merge. Are you an internal product manager? Reference the internal reviewing chart to tag the appropriate reviewer.
  • If the documentation involves a 1) paid SKU, 2) a third party, 3) SMS, 4) AI, or 5) privacy, ensure that Ana Teresa Serafino on the Legal team has signed off.
  • Tag others as reviewers as necessary.
  • If you have modified any links, be sure to add redirects to assets > js > broken_redirect_list.js
⭐ Helpful Wiki Shortcuts
❗ ATTN: For PR Reviewers
  • Read our Reviewing a PR page for more on our reviewing suggestions.
  • Read our Previewing Documentation page to see how to check the deployment.
    • Preview all changes in the linked Vercel environment by clicking the preview link in the vercel-bot comment in your PR.
❗ ATTN: Internal Reviewing Chart
Work at Braze and not sure who to tag for review?
Before tagging @josh-mccrowell-braze or @internetisaiah for a general review, reference the following chart to see if a specific product vertical/reviewer applies to your pull request.

Reviewer Product Vertical
@josh-mccrowell-braze Monolith Deployments
Quality Infrastructure
Platform Infrastructure
Datalake
SDKs
Currents
@internetisaiah Developer Guide
Technology partners
Channels
@bre-fitzgerald Intelligence
In-App Messages
Channels
Frontend Infrastructure & Experience (FIX)
@lydia-xie Ingestion
Core Objects
Core Messaging
Messaging Experience
Message Components
Email (Composition and Infrastructure) (tag @rachel-feinberg for Liquid use cases)
@rachel-feinberg Customer Lifecycle, Identity and Permissions
SMS
User Targeting
Reporting

@internetisaiah internetisaiah marked this pull request as ready for review July 18, 2024 01:49
@internetisaiah internetisaiah requested a review from mpmpmpmp1 July 18, 2024 01:49
@internetisaiah
Copy link
Contributor Author

Hey @mpmpmpmp1 , this one's ready for review! Let me know if you have any questions!

Copy link
Collaborator

@alex-braze alex-braze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in just a couple of thoughts/comments. Outside of those this looks good to me!

_docs/_partners/liveramp.md Outdated Show resolved Hide resolved
_docs/_partners/liveramp.md Outdated Show resolved Hide resolved
_docs/_partners/liveramp.md Outdated Show resolved Hide resolved
_docs/_partners/liveramp.md Outdated Show resolved Hide resolved
@internetisaiah
Copy link
Contributor Author

internetisaiah commented Jul 30, 2024

hey @alex-braze , took me a bit to figure out, but you may have reviewed an older version of the page that is not a reflection of the current page. that being said, i'm still going to try to apply your suggestions--but you may want to check out the latest deployment to double-check if there's anything else you want to change/add.

adjusting steps to conform to the LiveRamp processes
@internetisaiah
Copy link
Contributor Author

Hey @alex-braze , here's the new deployment with the changes we discussed:
https://braze-docs-akqmy2qmk-braze.vercel.app/docs/partners/data_and_infrastructure_agility/advertising/liveramp

If you could re-review when you have a second, that would be great! Thanks!

Copy link
Collaborator

@alex-braze alex-braze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two very very minor notes but approved otherwise!

Copy link
Collaborator

@alex-braze alex-braze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@internetisaiah
Copy link
Contributor Author

@cla-bot check

Copy link

cla-bot bot commented Aug 5, 2024

The cla-bot has been summoned, and re-checked this pull request!

@internetisaiah internetisaiah merged commit 2ed94ba into develop Aug 5, 2024
3 checks passed
@internetisaiah internetisaiah deleted the partner-liveramp-snowflake-braze branch August 5, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants