Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify MXToolbox behavior for DMARC authentication #7803

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Conversation

lydia-xie
Copy link
Contributor

Summary

Addresses feedback from #7770

Related PRs, issues, or features (optional)

  • N/A

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

@cla-bot cla-bot bot added the cla-signed label Aug 5, 2024
@lydia-xie lydia-xie changed the title Edits for Pull 7770 Clarify MXToolbox behavior for DMARC authentication Aug 5, 2024
@lydia-xie lydia-xie mentioned this pull request Aug 5, 2024
1 task
Copy link
Contributor

@rachel-feinberg rachel-feinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Left two small suggestions.

Co-authored-by: Rachel Feinberg <135255868+rachel-feinberg@users.noreply.github.com>
@lydia-xie lydia-xie merged commit 266da20 into develop Aug 5, 2024
3 checks passed
@lydia-xie lydia-xie deleted the lx-auth branch August 5, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants