Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BD-3349: Updates to translation API docs #7862

Merged
merged 8 commits into from
Aug 12, 2024
Merged

BD-3349: Updates to translation API docs #7862

merged 8 commits into from
Aug 12, 2024

Conversation

lydia-xie
Copy link
Contributor

Summary

My PR...

Related PRs, issues, or features (optional)

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

Copy link
Contributor

@kaiwah kaiwah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and apologies for missing these last round!
Also, should we add the fact that you can grab the locale_id UUID from the GET response? or is it already intuitive enough?

lydia-xie and others added 4 commits August 12, 2024 11:26
…gns.md

Co-authored-by: Kaiwah Ng <kaiwah.ng@gmail.com>
…es.md

Co-authored-by: Kaiwah Ng <kaiwah.ng@gmail.com>
…ign.md

Co-authored-by: Kaiwah Ng <kaiwah.ng@gmail.com>
…s.md

Co-authored-by: Kaiwah Ng <kaiwah.ng@gmail.com>
Copy link
Contributor

@kaiwah kaiwah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@internetisaiah internetisaiah merged commit 2b93dbe into develop Aug 12, 2024
3 checks passed
@internetisaiah internetisaiah deleted the BD-3349 branch August 12, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants