Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BD-3331: Importing CSV events EA #7866

Merged
merged 11 commits into from
Aug 13, 2024
Merged

BD-3331: Importing CSV events EA #7866

merged 11 commits into from
Aug 13, 2024

Conversation

lydia-xie
Copy link
Contributor

@lydia-xie lydia-xie commented Aug 9, 2024

Summary

Hidden article for CSV events early access

Related PRs, issues, or features (optional)

Feature release date (optional)

  • Week of August 12, 2024

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

@lydia-xie lydia-xie added the status: in progress Work in progress. label Aug 9, 2024
@lydia-xie lydia-xie self-assigned this Aug 9, 2024
@cla-bot cla-bot bot added the cla-signed label Aug 9, 2024
@lydia-xie lydia-xie changed the title BD-3331: CSV events EA BD-3331: Importing CSV events EA Aug 9, 2024
@lydia-xie
Copy link
Contributor Author

@cla-bot check

Copy link

cla-bot bot commented Aug 13, 2024

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Contributor

@internetisaiah internetisaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work overall, as always! Most of my suggestions are quick and easy. One is a little more involved. Let me know if I can help. I'm happy to try my hand at it as well, but wanted to give you priority first obviously.

_docs/_hidden/private_betas/csv_events.md Outdated Show resolved Hide resolved
_docs/_hidden/private_betas/csv_events.md Outdated Show resolved Hide resolved
_docs/_hidden/private_betas/csv_events.md Outdated Show resolved Hide resolved
_docs/_hidden/private_betas/csv_events.md Outdated Show resolved Hide resolved
_docs/_hidden/private_betas/csv_events.md Outdated Show resolved Hide resolved
_docs/_hidden/private_betas/csv_events.md Outdated Show resolved Hide resolved
_docs/_hidden/private_betas/csv_events.md Outdated Show resolved Hide resolved
_docs/_hidden/private_betas/csv_events.md Show resolved Hide resolved
_docs/_hidden/private_betas/csv_events.md Outdated Show resolved Hide resolved
_docs/_hidden/private_betas/csv_events.md Outdated Show resolved Hide resolved
Co-authored-by: isaiah robinson <95643215+internetisaiah@users.noreply.github.com>
Copy link
Contributor

@internetisaiah internetisaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 2! We are almost there!

_docs/_hidden/private_betas/csv_events.md Outdated Show resolved Hide resolved
_docs/_hidden/private_betas/csv_events.md Outdated Show resolved Hide resolved
_docs/_hidden/private_betas/csv_events.md Outdated Show resolved Hide resolved
_docs/_hidden/private_betas/csv_events.md Outdated Show resolved Hide resolved
_docs/_hidden/private_betas/csv_events.md Outdated Show resolved Hide resolved
_docs/_hidden/private_betas/csv_events.md Outdated Show resolved Hide resolved
Copy link
Contributor

@internetisaiah internetisaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for all the quick re-edits. I appreciate your collaboration 💪🏽

@lydia-xie lydia-xie merged commit 455f96d into develop Aug 13, 2024
3 checks passed
@lydia-xie lydia-xie deleted the BD-3331 branch August 13, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants