Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BD-3369 LINE update #7902

Merged
merged 8 commits into from
Aug 16, 2024
Merged

BD-3369 LINE update #7902

merged 8 commits into from
Aug 16, 2024

Conversation

rachel-feinberg
Copy link
Contributor

@rachel-feinberg rachel-feinberg commented Aug 14, 2024 •
edited by internetisaiah
Loading

Summary

My PR...

Related PRs, issues, or features (optional)

#BD-3369

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

@cla-bot cla-bot bot added the cla-signed label Aug 14, 2024
@rachel-feinberg rachel-feinberg self-assigned this Aug 14, 2024
@rachel-feinberg rachel-feinberg requested a review from a team August 16, 2024 16:21
@rachel-feinberg rachel-feinberg mentioned this pull request Aug 16, 2024
Closed
1 task
internetisaiah
internetisaiah approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@internetisaiah internetisaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as there are no suggestions I made that I think are 100% necessary. The only one's I think are worth adding are the ones that put the reader first (making them the active person in the sentence).

Other than that, great job!

_docs/_user_guide/message_building_by_channel/line/line_setup.md Outdated Show resolved Hide resolved
_docs/_user_guide/message_building_by_channel/line/line_setup.md Outdated Show resolved Hide resolved
_docs/_user_guide/message_building_by_channel/line/line_setup.md Outdated Show resolved Hide resolved
_docs/_user_guide/message_building_by_channel/line/line_setup.md Outdated Show resolved Hide resolved
_docs/_user_guide/message_building_by_channel/line/line_setup.md Outdated Show resolved Hide resolved
_docs/_user_guide/message_building_by_channel/line/line_setup.md Show resolved Hide resolved
_docs/_user_guide/message_building_by_channel/line/line_users/subscription_groups.md Outdated
@@ -12,7 +12,7 @@ permalink: /line/subscription_groups/

# LINE subscription groups

> There are two subscription states for LINE users: subscribed and unsubscribed. LINE can have up to 100 subscription groups per workspace, with each subscription group connected to its own LINE channel.<br><br>This article is part of the LINE beta collection. [Return to main page](https://www.braze.com/docs/line/).
> There are two subscription states for LINE users:x subscribed and unsubscribed. LINE can have up to 100 subscription groups per workspace, with each subscription group connected to its own LINE channel.<br><br>This article is part of the LINE beta collection. [Return to main page](https://www.braze.com/docs/line/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to have an added x?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope! Thanks for catching!

_docs/_user_guide/message_building_by_channel/line/line_users/user_management.md Outdated Show resolved Hide resolved
_docs/_user_guide/message_building_by_channel/line/line_users/user_management.md Outdated Show resolved Hide resolved
@rachel-feinberg @internetisaiah
Apply suggestions from code review
4e6e5f5 
Co-authored-by: isaiah robinson <95643215+internetisaiah@users.noreply.github.com>
@internetisaiah
Copy link
Contributor

Feel free to merge whenever @rachel-feinberg unless you're waiting for more reviews!

@rachel-feinberg rachel-feinberg merged commit eb7a07f into develop Aug 16, 2024
3 checks passed
@rachel-feinberg rachel-feinberg deleted the bd-3369 branch August 16, 2024 19:01
@lydia-xie lydia-xie mentioned this pull request Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@internetisaiah internetisaiah internetisaiah approved these changes

Assignees

@rachel-feinberg rachel-feinberg

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rachel-feinberg @internetisaiah @timcreasy