Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying commits from PR #8006 (Phrase) #8028

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

internetisaiah
Copy link
Contributor

@internetisaiah internetisaiah commented Sep 5, 2024

Summary

Copying commits over from #8006 without the commit history due to issues with cla-bot. I did this by:

git checkout develop && git pull
git checkout -b i18n_phrase-ja-isaiah-1318
git checkout i18n_phrase-ja _lang/ja/*
git commit -am "TITLE"
git push -u origin i18n_phrase-ja-isaiah-1318

Related PRs, issues, or features (optional)

  • N/A

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

Copy link
Contributor

@lydia-xie lydia-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lydia-xie lydia-xie merged commit a8ce284 into develop Sep 5, 2024
3 checks passed
@lydia-xie lydia-xie deleted the i18n_phrase-ja-isaiah-1318 branch September 5, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants