-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BD-3089 Create includes
file for metrics
#8055
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a spot check of most of the pages and looks like everything is rendering as expected. Lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left 2 comments for your review!
--- | ||
|
||
<style> | ||
.calculation-line { | ||
color: #76848C; | ||
font-size: 14px; | ||
} | ||
</style> | ||
======= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--- | |
<style> | |
.calculation-line { | |
color: #76848C; | |
font-size: 14px; | |
} | |
</style> | |
======= | |
--- | |
<style> | |
.calculation-line { | |
color: #76848C; | |
font-size: 14px; | |
} | |
</style> | |
======= |
@rachel-feinberg I think this area might've broken the page
.../_user_guide/message_building_by_channel/email/reporting_and_analytics/analytics_glossary.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Lydia Xie <87040416+lydia-xie@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing work as always, thanks for tackling this task 😎
Summary
My PR creates an includes file that contains metrics definitions, and inserts the include tag throughout the Docs site.
Related PRs, issues, or features (optional)
BD-3089
Feature release date (optional)
Contributor checklist
Submitting for review
If your PR meets the above requirements, select Ready for review, then add a reviewer:
braze-inc/docs-team
as the reviewer.braze-inc/docs-team
instead.Thanks for contributing! We look forward to reading your work.