Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BD-3089 Create includes file for metrics #8055

Merged
merged 15 commits into from
Oct 15, 2024
Merged

BD-3089 Create includes file for metrics #8055

merged 15 commits into from
Oct 15, 2024

Conversation

rachel-feinberg
Copy link
Contributor

Summary

My PR creates an includes file that contains metrics definitions, and inserts the include tag throughout the Docs site.

Related PRs, issues, or features (optional)

BD-3089

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
braze-docs-ko ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 5:22pm

@rachel-feinberg rachel-feinberg removed the status: in progress Work in progress. label Oct 8, 2024
Copy link
Collaborator

@bre-fitzgerald bre-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a spot check of most of the pages and looks like everything is rendering as expected. Lgtm!

Copy link
Contributor

@lydia-xie lydia-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 comments for your review!

Comment on lines 11 to 19
---

<style>
.calculation-line {
color: #76848C;
font-size: 14px;
}
</style>
=======
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
---
<style>
.calculation-line {
color: #76848C;
font-size: 14px;
}
</style>
=======
---
<style>
.calculation-line {
color: #76848C;
font-size: 14px;
}
</style>
=======

@rachel-feinberg I think this area might've broken the page
Screenshot 2024-10-15 at 9 22 18 AM

_includes/campaign_analytics.md Outdated Show resolved Hide resolved
rachel-feinberg and others added 2 commits October 15, 2024 09:52
Co-authored-by: Lydia Xie <87040416+lydia-xie@users.noreply.github.com>
Copy link
Contributor

@lydia-xie lydia-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing work as always, thanks for tackling this task 😎

@lydia-xie lydia-xie merged commit 64892c6 into develop Oct 15, 2024
5 checks passed
@lydia-xie lydia-xie deleted the bd-3089 branch October 15, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants