-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REP-3127] Update time window description for creating a report #8068
[REP-3127] Update time window description for creating a report #8068
Conversation
Change time window description when creating a report with campaigns / canvases to be within the last 12 months and not the last 6 months. This is the behavior of the product, so matching the description in the doc to the product. See https://jira.braze.com/browse/REP-3127 for more details
We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please fill out the information here. To re-call the cla-bot, comment |
@cla-bot check |
We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please fill out the information here. To re-call the cla-bot, comment |
The cla-bot has been summoned, and re-checked this pull request! |
Hi @exyrion ! Appreciate you rolling up your sleeves and jumping in to helping us keep the documentation up to date and accurate. Everybody that contributes to the docs does need to sign our Contributor License Agreement. Would you please fill out the information here and let me know when you've done so? Once that's complete and your reviewers have finished their review, please tag @braze-inc/docs-team and we'll be happy to merge your updates in. Let me know if you have any questions! |
Agreed to CLA and tagged with braze-inc/docs-team. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think i've signed the CLA either but this change looks ok from a Reporting team pov
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Change time window description when creating a report with campaigns / canvases to be within the last 12 months and not the last 6 months. This is the behavior of the product, so matching the description in the doc to the product. See https://jira.braze.com/browse/REP-3127 for more details