Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REP-3127] Update time window description for creating a report #8068

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

exyrion
Copy link
Contributor

@exyrion exyrion commented Sep 12, 2024

Change time window description when creating a report with campaigns / canvases to be within the last 12 months and not the last 6 months. This is the behavior of the product, so matching the description in the doc to the product. See https://jira.braze.com/browse/REP-3127 for more details

Change time window description when creating a report with campaigns / canvases to be within the last 12 months and not the last 6 months. This is the behavior of the product, so matching the description in the doc to the product. See https://jira.braze.com/browse/REP-3127 for more details
@exyrion exyrion requested review from calebsevern and a team September 12, 2024 23:27
Copy link

cla-bot bot commented Sep 12, 2024

We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please fill out the information here. To re-call the cla-bot, comment @cla-bot check.

@exyrion exyrion changed the title Update time window description for creating a report [REP-3127] Update time window description for creating a report Sep 12, 2024
@josh-mccrowell-braze
Copy link
Collaborator

@cla-bot check

Copy link

cla-bot bot commented Sep 13, 2024

We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please fill out the information here. To re-call the cla-bot, comment @cla-bot check.

Copy link

cla-bot bot commented Sep 13, 2024

The cla-bot has been summoned, and re-checked this pull request!

@josh-mccrowell-braze
Copy link
Collaborator

Hi @exyrion ! Appreciate you rolling up your sleeves and jumping in to helping us keep the documentation up to date and accurate.

Everybody that contributes to the docs does need to sign our Contributor License Agreement. Would you please fill out the information here and let me know when you've done so?

Once that's complete and your reviewers have finished their review, please tag @braze-inc/docs-team and we'll be happy to merge your updates in.

Let me know if you have any questions!

@exyrion exyrion requested a review from a team September 13, 2024 17:09
@exyrion exyrion closed this Sep 13, 2024
@exyrion exyrion reopened this Sep 13, 2024
@exyrion
Copy link
Contributor Author

exyrion commented Sep 13, 2024

Hi @exyrion ! Appreciate you rolling up your sleeves and jumping in to helping us keep the documentation up to date and accurate.

Everybody that contributes to the docs does need to sign our Contributor License Agreement. Would you please fill out the information here and let me know when you've done so?

Once that's complete and your reviewers have finished their review, please tag @braze-inc/docs-team and we'll be happy to merge your updates in.

Let me know if you have any questions!

Agreed to CLA and tagged with braze-inc/docs-team. Thanks

Copy link

@calebsevern calebsevern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think i've signed the CLA either but this change looks ok from a Reporting team pov

@lydia-xie
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Sep 13, 2024
Copy link

cla-bot bot commented Sep 13, 2024

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Contributor

@lydia-xie lydia-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lydia-xie lydia-xie merged commit 1c0e535 into develop Sep 13, 2024
3 checks passed
@lydia-xie lydia-xie deleted the REP-3127_report-builder-last-sent-restriction branch September 13, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants