Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UT-2091] Update Segment "Messaging Use" Docs #8127

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

diana-smirnova
Copy link
Contributor

@diana-smirnova diana-smirnova commented Sep 20, 2024

Why are you making this change? (required)

Clarifying that the segment "Messaging Use" section only include currently enabled campaigns / canvases. This came up in a PQ: https://servicedesk.braze.com/browse/PQ-5204
Also separating out the "Messaging use" and "Historical membership" sections since they're unrelated.

Related PRs, issues, or features (optional)

Ticket: UT-2091
PR that introduced this change: https://github.com/Appboy/platform/pull/55394

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

Copy link

cla-bot bot commented Sep 20, 2024

We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please fill out the information here. To re-call the cla-bot, comment @cla-bot check.

@diana-smirnova
Copy link
Contributor Author

@cla-bot check

Copy link

cla-bot bot commented Sep 20, 2024

We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please fill out the information here. To re-call the cla-bot, comment @cla-bot check.

Copy link

cla-bot bot commented Sep 20, 2024

The cla-bot has been summoned, and re-checked this pull request!

@diana-smirnova
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Sep 20, 2024
Copy link

cla-bot bot commented Sep 20, 2024

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Contributor

@rachel-feinberg rachel-feinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@rachel-feinberg rachel-feinberg merged commit 484be32 into develop Sep 23, 2024
3 checks passed
@rachel-feinberg rachel-feinberg deleted the ut-2091-update-segment-messaging-use-docs branch September 23, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants