Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BD-3509 Add LINE message types #8143

Merged
merged 10 commits into from
Oct 1, 2024
Merged

BD-3509 Add LINE message types #8143

merged 10 commits into from
Oct 1, 2024

Conversation

rachel-feinberg
Copy link
Contributor

@rachel-feinberg rachel-feinberg commented Sep 23, 2024

Why are you making this change? (required)

Add LINE message types article

Related PRs, issues, or features (optional)

BD-3509

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
braze-docs-ko ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2024 5:45pm

@rachel-feinberg
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Sep 25, 2024
Copy link

cla-bot bot commented Sep 25, 2024

The cla-bot has been summoned, and re-checked this pull request!

Co-authored-by: Bre Fitzgerald <82903296+bre-fitzgerald@users.noreply.github.com>
Copy link
Contributor

@internetisaiah internetisaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. Also agree with Bre's open comment as well. Great work overall!

Co-authored-by: isaiah robinson <95643215+internetisaiah@users.noreply.github.com>
Copy link
Collaborator

@bre-fitzgerald bre-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@internetisaiah internetisaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rachel-feinberg rachel-feinberg merged commit ad62573 into develop Oct 1, 2024
5 checks passed
@rachel-feinberg rachel-feinberg deleted the bd-3509 branch October 1, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants