Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-3522 ] Fixing redirect for legacy iOS #8155

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

internetisaiah
Copy link
Contributor

@internetisaiah internetisaiah commented Sep 26, 2024

Why are you making this change? (required)

Fixing some misc redirects for legacy iOS docs. The primary request is to make the /initial_sdk_setup/ config only page redirect to the /initial_sdk_setup/overview.md page since this link has been directly embedded in the product for some time.

Related PRs, issues, or features (optional)

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

@internetisaiah internetisaiah self-assigned this Sep 26, 2024
Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
braze-docs-ko ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 8:51pm

@internetisaiah internetisaiah changed the title Fixing redirect for legacy iOS [BD-3522 ] Fixing redirect for legacy iOS Sep 26, 2024
@internetisaiah internetisaiah marked this pull request as ready for review September 26, 2024 18:06
Copy link
Contributor

@lydia-xie lydia-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redirect works but https://braze-docs-7m0e76fhk-braze.vercel.app/docs/developer_guide/platform_integration_guides/legacy_sdks/ios/initial_sdk_setup is showing up as a blank page when I select Initial SDK setup in the left nav 🤔

@internetisaiah
Copy link
Contributor Author

@lydia-xie , ugh thanks. i'll fix that before merging. it just might not be possible to do a redirect.

@internetisaiah internetisaiah merged commit 8f0995b into develop Sep 26, 2024
5 checks passed
@internetisaiah internetisaiah deleted the internetisaiah-patch-5 branch September 26, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants