Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Untracked] Add note that Live Activities requires a .p8 key #8209

Merged

Conversation

hokstuff
Copy link
Contributor

@hokstuff hokstuff commented Oct 3, 2024

Why are you making this change? (required)

Related PRs, issues, or features (optional)

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

@cla-bot cla-bot bot added the cla-signed label Oct 3, 2024
@hokstuff hokstuff requested a review from a team October 3, 2024 19:05
Copy link
Contributor

@vanessaland vanessaland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hokstuff
Copy link
Contributor Author

hokstuff commented Oct 3, 2024

@internetisaiah This PR is ready to be reviewed by the Docs team and merged + released afterwards

@internetisaiah internetisaiah self-assigned this Oct 3, 2024
@hokstuff
Copy link
Contributor Author

hokstuff commented Oct 7, 2024

Hi @josh-mccrowell-braze, since Isiah is out, would you be able to take a quick look and then merge + release when you have a chance? Thank you!

@josh-mccrowell-braze josh-mccrowell-braze merged commit 28f7f3f into develop Oct 8, 2024
5 checks passed
@josh-mccrowell-braze josh-mccrowell-braze deleted the untracked-LiveActivites-p8RequirementDocs branch October 8, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants